Add user-definable ottavation markups

Add user-definable ottavation markups

The context property ottavationMarkups is an alist containing markups
for different octaves. Entries 22ma, 29ma, 22mb, and 29mb were added.

There is a warning when \ottava uses a number of octaves that has no
corresponding markup (alist entry).

Contains regtest

[Malte Meyn, 2019-09-27 08:57:35]

https://codereview.appspot.com/568970043/diff/551000043/scm/define-music-call...
File scm/define-music-callbacks.scm (right):

https://codereview.appspot.com/568970043/diff/551000043/scm/define-music-call...
scm/define-music-callbacks.scm:87: (ly:warning "Could not find ottavation markup
for ~a octaves up." octavation))
Has this to be made translatable? If so, how? I didn’t really understand the CG
here. IIUC, I just could write (ly:warning (_ "Could not find … ~a octaves up")
octavation) but that might be wrong. Would I have to add translations or
translation placeholders?

[Malte Meyn, 2019-09-30 19:51:43]

https://codereview.appspot.com/568970043/diff/551000043/ly/engraver-init.ly
File ly/engraver-init.ly (right):

https://codereview.appspot.com/568970043/diff/551000043/ly/engraver-init.ly#n...
ly/engraver-init.ly:107: ottavationMarkups =
Should we change the defaults to something more beautiful? I’d vote for
sub/superscript va/vb or numbers only.

[kieren_macmillan_sympatico.ca, 2019-09-30 20:00:29]

Hi all,

>
https://codereview.appspot.com/568970043/diff/551000043/ly/engraver-init.ly#n...
> ly/engraver-init.ly:107: ottavationMarkups =
> Should we change the defaults to something more beautiful? I’d vote for
> sub/superscript va/vb or numbers only.

+1

I’m happy to submit a [regular markup] version for consideration, if OP doesn’t
want to do that.

Cheers,
Kieren.
________________________________

Kieren MacMillan, composer (he/him/his)
‣ website: www.kierenmacmillan.info
‣ email: info@kierenmacmillan.info

[Malte Meyn, 2019-10-01 15:21:43]

On 2019/09/30 20:00:29, kieren_macmillan_sympatico.ca wrote:
> I’m happy to submit a [regular markup] version for consideration, if OP
doesn’t
> want to do that.

After playing a bit with font sizes I think I found a good solution
(sub/superscript aligned with general-align, font-size -2). I’ll upload it soon
but first I have to fix a regression (ambitus-ottava.ly).

[Malte Meyn, 2019-10-01 15:56:21]

change default ottavationMarkups, adapt regtest, fix ambitus regression

[Malte Meyn, 2019-10-01 15:59:19]

correct line lengths

[Malte Meyn, 2019-10-02 08:23:53]

change default again (to simple numbers, bold series)

[Malte Meyn, 2019-10-02 08:30:24]

On 2019/10/02 08:23:53, Malte Meyn wrote:
> change default again (to simple numbers, bold series)

There are now three predefined options: #ottava-numbers (default),
#ottava-ordinals (might be wanted as an alternative by many),
#ottava-simple-ordinals (for those who don’t like change).

Documentation of all ottava changes (5559, 5563, and vertical alignment) will
follow with the last of these.

[Malte Meyn, 2019-10-02 08:36:33]

https://codereview.appspot.com/568970043/diff/547000043/scm/translation-funct...
File scm/translation-functions.scm (right):

https://codereview.appspot.com/568970043/diff/547000043/scm/translation-funct...
scm/translation-functions.scm:909: (3 . "22")
I’ll correct this indentation with the next patch set (if there is none, before
pushing to staging).

[Malte Meyn, 2019-10-02 11:11:25]

make bassa ordinals end on va/ma

[Malte Meyn, 2019-10-02 11:12:08]

On 2019/10/02 11:11:25, Malte Meyn wrote:
> make bassa ordinals end on va/ma

Not for #ottava-simple-ordinals for compatibility reasons. But who wants to use
that anyway? ;)