Issue 5687086: fall back to CGFont to get a font table

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5687086: fall back to CGFont to get a font table

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by reed1

Modified:
12 years, 2 months ago

Reviewers:
caryclark1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 1

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	src/ports/SkFontHost_mac_coretext.cpp	View		3 chunks	+12 lines, -4 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

caryclark1

https://codereview.appspot.com/5687086/diff/1/src/ports/SkFontHost_mac_coretext.cpp File src/ports/SkFontHost_mac_coretext.cpp (right): https://codereview.appspot.com/5687086/diff/1/src/ports/SkFontHost_mac_coretext.cpp#newcode1919 src/ports/SkFontHost_mac_coretext.cpp:1919: data = CGFontCopyTableForTag(cgFont, tag); where do you do the ...

12 years, 2 months ago (2012-02-23 13:23:38 UTC) #1

reed1

12 years, 2 months ago (2012-02-23 13:31:26 UTC) #2

feel free to land this as if if you like, and I can refactor later.

Expand All Messages | Collapse All Messages