Issue 5685064: trivial: Parse --zookeeper-servers directly into a state.Info

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5685064: trivial: Parse --zookeeper-servers directly into a state.Info

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by fwereade

Modified:
12 years, 2 months ago

Reviewers:
mp+94004

Visibility:
Public.

Description

...so we can pass it directly to state.Open when the time comes. https://code.launchpad.net/~fwereade/juju/go-parse-state-info/+merge/94004 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : trivial: Parse --zookeeper-servers directly into a state.Info #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -31 lines)			Patch
M	cmd/jujud/agent.go	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	cmd/jujud/export_test.go	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	cmd/jujud/flag.go	View	3 chunks	+14 lines, -13 lines	0 comments	Download
M	cmd/jujud/initzk.go	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	cmd/jujud/initzk_test.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	cmd/jujud/util_test.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

On 2012/02/21 15:19:22, fwereade wrote: > Please take a look. LGTM

12 years, 2 months ago (2012-02-21 15:25:45 UTC) #2

fwereade

12 years, 2 months ago (2012-02-21 15:28:43 UTC) #3

*** Submitted:

trivial: Parse --zookeeper-servers directly into a state.Info

...so we can pass it directly to state.Open when the time comes.

R=rog
CC=
https://codereview.appspot.com/5685064

Expand All Messages | Collapse All Messages