Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(79)

Issue 5676067: code review 5676067: net/mail: make address parsing (more) public

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by gmiller
Modified:
9 years, 9 months ago
Reviewers:
dsymonds
CC:
dsymonds, golang-dev
Visibility:
Public.

Description

net/mail: make address parsing (more) public Code for parsing email addresses was already partially part of the public API with "func (Header) AddressList". This CL adds a trivial implementation for two public methods to parse address and lists from a string. With tests.

Patch Set 1 #

Patch Set 2 : diff -r c9dae91ce714 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c9dae91ce714 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M src/pkg/net/mail/message.go View 1 2 chunks +11 lines, -1 line 0 comments Download
M src/pkg/net/mail/message_test.go View 1 1 chunk +14 lines, -3 lines 0 comments Download

Messages

Total messages: 6
gmiller
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 4 months ago (2012-02-16 17:59:06 UTC) #1
rsc
Sorry, the APIs for Go 1 are frozen. Please remind us about this CL after ...
10 years, 4 months ago (2012-02-16 20:15:17 UTC) #2
rsc
10 years, 1 month ago (2012-06-03 04:45:06 UTC) #3
gmiller
Is this CL something that might be appropriate for Go 1.1?
9 years, 9 months ago (2012-10-02 14:34:26 UTC) #4
dsymonds
LGTM Seems reasonable to me. I'll give it a couple of days for others to ...
9 years, 9 months ago (2012-10-02 22:53:50 UTC) #5
dsymonds
9 years, 9 months ago (2012-10-05 00:09:09 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=fc0c1a909822 ***

net/mail: make address parsing (more) public

Code for parsing email addresses was already partially part of the public API
with "func (Header) AddressList".  This CL adds a trivial implementation for two
public methods to parse address and lists from a string. With tests.

R=dsymonds
CC=golang-dev
http://codereview.appspot.com/5676067

Committer: David Symonds <dsymonds@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b