Issue 5675051: Explicitly make the rlz targets win-only (for now).

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5675051: Explicitly make the rlz targets win-only (for now). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by thakis

Modified:
14 years, 1 month ago

Reviewers:
cpu, Roger Tawa, gwilson

CC:
rlz-codereviews_googlegroups.com

Base URL:
http://rlz.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Explicitly make the rlz targets win-only (for now). BUG=chromium:46579

Patch Set 1 #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -69 lines)			Patch
	M	rlz.gyp	View		1 chunk	+73 lines, -69 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thakis

The plan is to then pull rlz on mac too, and then slowly extract cross-platform ...

14 years, 2 months ago (2012-02-15 00:26:05 UTC) #1

thakis

Looks like rogerta is out for today and on vacation tomorrow. gwilson or cpu, can ...

14 years, 2 months ago (2012-02-15 00:56:38 UTC) #2

gwilson

14 years, 2 months ago (2012-02-15 01:00:55 UTC) #3

On 2012/02/15 00:56:38, thakis wrote:
> Looks like rogerta is out for today and on vacation tomorrow. gwilson or cpu,
> can you take a look?

lgtm, from what [little] I know of gyp.  Will wait for the DEPS roll to see if
it passes the tests on mac/linux

Expand All Messages | Collapse All Messages