Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(379)

Issue 5672082: code review 5672082: go.net: gofix for net/url API changes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by dsymonds
Modified:
1 year, 1 month ago
Reviewers:
r, duystars21
CC:
golang-dev, r
Visibility:
Public.

Description

go.net: gofix for net/url API changes.

Patch Set 1 #

Patch Set 2 : diff -r c31413e220a0 https://code.google.com/p/go.net #

Patch Set 3 : diff -r c31413e220a0 https://code.google.com/p/go.net #

Patch Set 4 : diff -r c31413e220a0 https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M websocket/client.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M websocket/hixie.go View 1 4 chunks +4 lines, -4 lines 0 comments Download
M websocket/hixie_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M websocket/hybi.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M websocket/hybi_test.go View 1 2 chunks +4 lines, -4 lines 0 comments Download
M websocket/websocket_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
dsymonds
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.net
12 years, 3 months ago (2012-02-17 22:04:27 UTC) #1
dsymonds
This is a mechanical (gofixed) change to fix the build. Can someone take a quick ...
12 years, 3 months ago (2012-02-18 01:47:05 UTC) #2
r
LGTM
12 years, 3 months ago (2012-02-18 01:48:39 UTC) #3
dsymonds
*** Submitted as d7ff1d8f275c *** go.net: gofix for net/url API changes. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5672082
12 years, 3 months ago (2012-02-18 01:49:47 UTC) #4
duystars21
1 year, 1 month ago (2023-04-05 13:55:24 UTC) #5
Message was sent while issue was closed.
Chevroletm@my.com
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b