Issue 5671070: Deploy now accepts an upgrade flag.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5671070: Deploy now accepts an upgrade flag.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by hazmat

Modified:
12 years, 2 months ago

Reviewers:
jimbaker, mp+93482, bcsaller

Visibility:
Public.

Description

As part of feedback given on the mailing list, its become clear that we need a way to allow users to automatically increment charm revisions while iterating in development. Charm upgrade already provides for this, but deploy should as well. For an on disk repository, using directory charms, passing a -u/--upgrade flag will now automatically increment the revision before deployment. https://code.launchpad.net/~hazmat/juju/deploy-upgrade/+merge/93482 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+128 lines, -7 lines)			Patch
M	juju/charm/bundle.py	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	juju/charm/directory.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	juju/charm/publisher.py	View	3 chunks	+5 lines, -0 lines	0 comments	Download
M	juju/charm/repository.py	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	juju/charm/tests/test_bundle.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	juju/charm/tests/test_directory.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	juju/charm/tests/test_publisher.py	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	juju/charm/tests/test_repository.py	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	juju/control/deploy.py	View	5 chunks	+16 lines, -1 line	0 comments	Download
M	juju/control/tests/test_deploy.py	View	4 chunks	+87 lines, -6 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jimbaker

+1, LGTM! https://codereview.appspot.com/5671070/diff/1/juju/charm/bundle.py File juju/charm/bundle.py (right): https://codereview.appspot.com/5671070/diff/1/juju/charm/bundle.py#newcode17 juju/charm/bundle.py:17: type = "bundle" It's not clear to ...

12 years, 2 months ago (2012-02-23 21:21:13 UTC) #2

bcsaller

12 years, 2 months ago (2012-02-29 23:33:22 UTC) #3

+1 after trivial in test

https://codereview.appspot.com/5671070/diff/1/juju/control/tests/test_deploy.py
File juju/control/tests/test_deploy.py (right):

https://codereview.appspot.com/5671070/diff/1/juju/control/tests/test_deploy....
juju/control/tests/test_deploy.py:183: print output.getvalue()
remove the try/except: print

Expand All Messages | Collapse All Messages