Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(761)

Issue 566920044: Replace deprecated functions from string module

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by hahnjo
Modified:
3 weeks, 5 days ago
Reviewers:
dak, Malte Meyn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Replace deprecated functions from string module These methods have been deprecated since at least Python 2.4 and their replacements are available since at least that version. Individual changes: * Replace string.atoi() by int() * Replace string.split() by str.split() * Replace string.join() by sep.join() * Replace string.strip() by str.strip() * Replace string.replace() by str.replace() * Drop now unused 'import string'

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -41 lines) Patch
M python/convertrules.py View 3 chunks +3 lines, -3 lines 0 comments Download
M python/musicexp.py View 10 chunks +10 lines, -11 lines 2 comments Download
M python/musicxml.py View 5 chunks +4 lines, -5 lines 0 comments Download
M python/utilities.py View 2 chunks +1 line, -2 lines 0 comments Download
M scripts/auxiliar/fixcc.py View 2 chunks +1 line, -2 lines 0 comments Download
M scripts/build/install.py View 2 chunks +1 line, -2 lines 0 comments Download
M scripts/build/text2html.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/lilymidi.py View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/musicxml2ly.py View 11 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 6
Malte Meyn
For someone who doesn’t know python two questions come up: 1. Why do you sometimes ...
3 weeks, 6 days ago (2019-10-23 21:22:16 UTC) #1
Malte Meyn
On 2019/10/23 21:22:16, Malte Meyn wrote: > 2. Is a space (" " or ' ...
3 weeks, 6 days ago (2019-10-23 21:29:27 UTC) #2
hahnjo
On 2019/10/23 21:22:16, Malte Meyn wrote: > For someone who doesn’t know python two questions ...
3 weeks, 6 days ago (2019-10-24 06:33:50 UTC) #3
dak
jonas.hahnfeld@gmail.com writes: > Reviewers: Malte Meyn, > > Message: > On 2019/10/23 21:22:16, Malte Meyn ...
3 weeks, 5 days ago (2019-10-24 07:36:50 UTC) #4
hahnjo
On 2019/10/24 07:36:50, dak wrote: > mailto:jonas.hahnfeld@gmail.com writes: > > > Reviewers: Malte Meyn, > ...
3 weeks, 5 days ago (2019-10-24 07:40:30 UTC) #5
dak
3 weeks, 5 days ago (2019-10-24 11:30:21 UTC) #6
jonas.hahnfeld@gmail.com writes:

> On 2019/10/24 07:36:50, dak wrote:
>
>> git cl upload allows you to edit the message.  You can edit in a
>> suitably edited version of git log (typically I put something like
>> Contains commits: at the end of the principal text and then a lightly
>> edited list of reverse commit messages)
>
>> Tastes differ, but one has the opportunity to give more information.
>
> Yeah, messed this up I guess. I had expected that I only entered the
> cover description and that the separate commits would be uploaded as
> sub-revisions or something. Will pay more attention in the future.

That would be a reasonable expectation given a Git-centric project tool.
But we are working with some Google tools on a code review site created
for Subversion and have migrated the Google code part more or less to
SourceForge as a stopgap measure before managing self-hosting on the
Free version of its software, a step that we never managed due to a lack
of manpower and ongoing resource needs.  All the while having the
repository itself on Savannah.

So it turns out that a few things that would be obvious candidates for
automation just aren't up to scratch.

On the plus side, "messed this up" seems way overblown for "didn't score
a perfect 10 in a quagmire I got into for the first time".  Our
procedures tend to avoid annoying more than one person at a time, so
it's pretty uncommon that tempers flare up.

> https://codereview.appspot.com/566920044/

-- 
David Kastrup
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b