Issue 56660043: Encode TLS messages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 56660043: Encode TLS messages

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by ekasper

Modified:
10 years, 3 months ago

Reviewers:
Eran

CC:
ctlog-opensource-review_google.com

Visibility:
Public.

More Reviews

Description

Encode TLS messages

Patch Set 1 #

Patch Set 2 : fix Eran's script #

Total comments: 2

Patch Set 3 : comment #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+231 lines, -27 lines)			Patch
M	src/python/ct/client/tls_message.py	View	1 2	4 chunks	+148 lines, -3 lines	0 comments	Download
M	src/python/ct/client/tls_message_test.py	View		3 chunks	+69 lines, -3 lines	0 comments	Download
M	src/python/ct/client/tools/scan.py	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/python/ct/client/tools/verify_single_proof.py	View	1	3 chunks	+12 lines, -17 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Eran

Overall LGTM, see one comment below. I'd have liked to see the struct package being ...

10 years, 3 months ago (2014-01-27 16:46:40 UTC) #2

ekasper

On 2014/01/27 16:46:40, Eran wrote: > Overall LGTM, see one comment below. > I'd have ...

10 years, 3 months ago (2014-01-28 19:03:55 UTC) #3

ekasper

10 years, 3 months ago (2014-01-28 19:04:05 UTC) #4

https://codereview.appspot.com/56660043/diff/20001/src/python/ct/client/tls_m...
File src/python/ct/client/tls_message.py (right):

https://codereview.appspot.com/56660043/diff/20001/src/python/ct/client/tls_m...
src/python/ct/client/tls_message.py:170: def get_result(self):
On 2014/01/27 16:46:40, Eran wrote:
> Nit: Name get_serialized or serialize or something similar? Or make it
private.

Renamed to get_serialized_result. Since write() is public, this has to be
public, too. Using encode() to serialize a single message probably covers most
uses but I think it's nice to have the manual option around, too.

Expand All Messages | Collapse All Messages