Issue 5661046: Refactor the machine agent so that unit agent management is moved to a separate class.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5661046: Refactor the machine agent so that unit agent management is moved to a separate class.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by Jim Baker

Modified:
12 years, 1 month ago

Reviewers:
hazmat, mp+91167

Visibility:
Public.

Description

Subordinate support requires that a machine agent or a unit agent can start/stop unit agents. This refactoring moves this support out of juju.agents.machine and into juju.state.unit.UnitManager (so similar placement to juju.state.firewall and the future statusd support). https://code.launchpad.net/~jimbaker/juju/refactor-machine-agent/+merge/91167 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+306 lines, -148 lines)			Patch
M	juju/agents/machine.py	View	8 chunks	+9 lines, -74 lines	0 comments	Download
M	juju/agents/tests/test_machine.py	View	8 chunks	+26 lines, -54 lines	0 comments	Download
M	juju/hooks/tests/test_invoker.py	View	3 chunks	+2 lines, -15 lines	0 comments	Download
M	juju/lib/testing.py	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	juju/state/machine.py	View	1 chunk	+1 line, -5 lines	0 comments	Download
A	juju/state/tests/test_unit.py	View	1 chunk	+146 lines, -0 lines	0 comments	Download
A	juju/state/unit.py	View	1 chunk	+101 lines, -0 lines	1 comment	Download
M	juju/unit/charm.py	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hazmat

12 years, 1 month ago (2012-03-15 17:54:03 UTC) #2

LGTM

https://codereview.appspot.com/5661046/diff/1/juju/state/unit.py
File juju/state/unit.py (right):

https://codereview.appspot.com/5661046/diff/1/juju/state/unit.py#newcode33
juju/state/unit.py:33: assert isinstance(machine_id, str)
if your going to sanity check this here, then might as well do the same for
juju_directory.

Expand All Messages | Collapse All Messages