Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(318)

Issue 5661044: Bug 1111 - new classes and refactoring RouteOutput()

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by Campiolo
Modified:
6 years, 9 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This solution is based in applied patch issue5417048_25003.diff in revision 7703 We use some ideas proposed by Tommaso and Tom. The main focus of the discussion are the classes to represent flowi structure, see file flowi.h and flowi.cc. thanks for comments.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+580 lines, -155 lines) Patch
M src/aodv/model/aodv-routing-protocol.h View 1 chunk +1 line, -1 line 0 comments Download
M src/aodv/model/aodv-routing-protocol.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M src/click/model/ipv4-click-routing.h View 1 chunk +1 line, -1 line 0 comments Download
M src/click/model/ipv4-click-routing.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M src/dsdv/model/dsdv-routing-protocol.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/dsdv/model/dsdv-routing-protocol.cc View 1 chunk +7 lines, -4 lines 0 comments Download
A src/internet/model/flowi.h View 1 chunk +172 lines, -0 lines 0 comments Download
A src/internet/model/flowi.cc View 1 chunk +182 lines, -0 lines 0 comments Download
M src/internet/model/icmpv4-l4-protocol.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/internet/model/icmpv6-l4-protocol.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M src/internet/model/ipv4-global-routing.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/internet/model/ipv4-global-routing.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/internet/model/ipv4-l3-protocol.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/internet/model/ipv4-list-routing.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/internet/model/ipv4-list-routing.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/internet/model/ipv4-raw-socket-impl.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/internet/model/ipv4-routing-protocol.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/internet/model/ipv4-static-routing.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/internet/model/ipv4-static-routing.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/internet/model/ipv6-extension.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/internet/model/ipv6-l3-protocol.cc View 1 chunk +7 lines, -1 line 0 comments Download
M src/internet/model/ipv6-list-routing.h View 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/ipv6-list-routing.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/internet/model/ipv6-raw-socket-impl.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/internet/model/ipv6-routing-protocol.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/internet/model/ipv6-static-routing.h View 1 chunk +1 line, -1 line 0 comments Download
M src/internet/model/ipv6-static-routing.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/internet/model/tcp-l4-protocol.cc View 4 chunks +38 lines, -20 lines 0 comments Download
M src/internet/model/tcp-socket-base.cc View 2 chunks +18 lines, -8 lines 0 comments Download
M src/internet/model/udp-socket-impl.cc View 3 chunks +20 lines, -14 lines 0 comments Download
M src/internet/test/ipv4-list-routing-test-suite.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/internet/test/ipv6-list-routing-test-suite.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/internet/wscript View 2 chunks +2 lines, -0 lines 0 comments Download
M src/network/utils/packet-socket.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/nix-vector-routing/model/ipv4-nix-vector-routing.h View 1 chunk +1 line, -1 line 0 comments Download
M src/nix-vector-routing/model/ipv4-nix-vector-routing.cc View 8 chunks +18 lines, -15 lines 0 comments Download
M src/olsr/model/olsr-routing-protocol.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/olsr/model/olsr-routing-protocol.cc View 5 chunks +18 lines, -15 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b