Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1103)

Issue 565750043: Added vowel transitions for lyrics

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by davidsg
Modified:
3 months, 2 weeks ago
Reviewers:
dak, dan, lemzwerg, Dan Eble, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

A vowel transition may be drawn as an arrow from one syllable to another, and indicates a gradual change of vowel (see Gould pp. 452--453). Input with the command \vowelTransition between lyric syllables.

Patch Set 1 #

Total comments: 9

Patch Set 2 : Renamed 'transition line' to 'transition arrow' and documentation fixes. #

Patch Set 3 : Revision following review #

Patch Set 4 : Removed transition-engraver.cc #

Total comments: 4

Patch Set 5 : Rename to vowel-transition-event #

Total comments: 2

Patch Set 6 : Corrected VowelTransitionEvent description #

Patch Set 7 : Added check to prevent issue if some bounds properties were not available. #

Patch Set 8 : Replaced property 'minimum-length-includes-padding' with 'minimum-length-correction'. #

Total comments: 11

Patch Set 9 : Rebased on top of current master. #

Patch Set 10 : Revisions following review #

Total comments: 4

Patch Set 11 : Corrections following review. #

Patch Set 12 : Restored accidentally deleted empty line. #

Patch Set 13 : Apologies for the noise for the last two patch sets. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+570 lines, -12 lines) Patch
M Documentation/changes.tely View 1 2 3 4 5 6 7 8 1 chunk +10 lines, -0 lines 0 comments Download
M Documentation/music-glossary.tely View 1 2 3 4 2 chunks +20 lines, -0 lines 0 comments Download
M Documentation/notation/vocal.itely View 1 2 3 4 5 6 7 8 9 2 chunks +43 lines, -0 lines 0 comments Download
A input/regression/vowel-transition.ly View 1 2 3 4 5 6 7 8 9 1 chunk +20 lines, -0 lines 0 comments Download
A input/regression/vowel-transition-broken.ly View 1 2 3 4 5 6 7 8 9 1 chunk +31 lines, -0 lines 0 comments Download
A input/regression/vowel-transition-delayed-start.ly View 1 2 3 4 5 6 7 8 9 1 chunk +23 lines, -0 lines 0 comments Download
A input/regression/vowel-transition-minimum-length.ly View 1 2 3 4 5 6 7 8 9 10 1 chunk +68 lines, -0 lines 0 comments Download
A input/regression/vowel-transition-offset-syllable.ly View 1 2 3 4 5 6 7 8 9 1 chunk +24 lines, -0 lines 0 comments Download
A input/regression/vowel-transition-padding.ly View 1 2 3 4 5 6 7 8 9 1 chunk +45 lines, -0 lines 0 comments Download
A input/regression/vowel-transition-padding-broken.ly View 1 2 3 4 5 6 7 8 9 1 chunk +49 lines, -0 lines 0 comments Download
A input/regression/vowel-transition-right-margin.ly View 1 2 3 4 5 6 7 8 9 1 chunk +27 lines, -0 lines 0 comments Download
M lily/hyphen-engraver.cc View 1 2 3 4 5 6 7 8 9 10 12 4 chunks +17 lines, -3 lines 0 comments Download
A + lily/include/vowel-transition.hh View 1 2 3 4 5 6 7 8 9 2 chunks +9 lines, -8 lines 0 comments Download
A lily/vowel-transition.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +140 lines, -0 lines 0 comments Download
M ly/property-init.ly View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M scm/define-event-classes.scm View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M scm/define-grobs.scm View 1 2 3 4 5 6 7 8 9 1 chunk +30 lines, -0 lines 0 comments Download
M scm/define-music-types.scm View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M scm/safe-lily.scm View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 39
davidsg
I've been working on this feature I would like to propose for LilyPond, and I ...
4 months ago (2020-03-08 14:38:25 UTC) #1
lemzwerg
Looks very nice, thanks! I must admit that I've never seen such a feature before, ...
4 months ago (2020-03-08 14:58:24 UTC) #2
hanwenn
I think it would be better to do this as something that doesn't require special ...
4 months ago (2020-03-08 15:21:22 UTC) #3
hanwenn
https://codereview.appspot.com/565750043/diff/553650043/lily/lyric-transition.cc File lily/lyric-transition.cc (right): https://codereview.appspot.com/565750043/diff/553650043/lily/lyric-transition.cc#newcode103 lily/lyric-transition.cc:103: As r is a fresh rod, we can set ...
4 months ago (2020-03-08 15:25:08 UTC) #4
davidsg
Renamed 'transition line' to 'transition arrow' and documentation fixes.
4 months ago (2020-03-08 20:09:22 UTC) #5
davidsg
On 2020/03/08 15:21:22, hanwenn wrote: > I think it would be better to do this ...
4 months ago (2020-03-08 20:32:03 UTC) #6
dan_faithful.be
On Mar 8, 2020, at 11:21, hanwenn@gmail.com wrote: > > I think it would be ...
4 months ago (2020-03-08 23:44:43 UTC) #7
hanwenn
On Mon, Mar 9, 2020 at 12:44 AM Dan Eble <dan@faithful.be> wrote: > I agree ...
4 months ago (2020-03-09 08:42:43 UTC) #8
dan_faithful.be
On Mar 9, 2020, at 04:42, Han-Wen Nienhuys <hanwenn@gmail.com> wrote: > > On Mon, Mar ...
4 months ago (2020-03-10 00:41:50 UTC) #9
hanwenn
On Tue, Mar 10, 2020 at 1:41 AM Dan Eble <dan@faithful.be> wrote: > > On ...
4 months ago (2020-03-10 08:14:03 UTC) #10
dak
Han-Wen Nienhuys <hanwenn@gmail.com> writes: > On Tue, Mar 10, 2020 at 1:41 AM Dan Eble ...
4 months ago (2020-03-10 09:33:45 UTC) #11
davidsg
Revision following review
4 months ago (2020-03-10 09:59:29 UTC) #12
davidsg
On 2020/03/10 09:59:29, davidsg wrote: > Revision following review Removed -> as special syntax, and ...
4 months ago (2020-03-10 10:05:46 UTC) #13
hanwenn
On 2020/03/10 10:05:46, davidsg wrote: > On 2020/03/10 09:59:29, davidsg wrote: > > Revision following ...
4 months ago (2020-03-10 18:12:13 UTC) #14
davidsg
Removed transition-engraver.cc
4 months ago (2020-03-11 00:32:26 UTC) #15
davidsg
On 2020/03/11 00:32:26, davidsg wrote: > Removed transition-engraver.cc hyphen-engraver now also listens for transition-events, and ...
4 months ago (2020-03-11 00:34:32 UTC) #16
dan_faithful.be
On Mar 10, 2020, at 04:13, Han-Wen Nienhuys <hanwenn@gmail.com> wrote: > I never said that ...
4 months ago (2020-03-11 02:02:20 UTC) #17
Dan Eble
On 2020/03/11 00:34:32, davidsg wrote: > hyphen-engraver now also listens for transition-events, and makes transitions ...
4 months ago (2020-03-11 02:30:04 UTC) #18
lemzwerg
Some more nits :-) https://codereview.appspot.com/565750043/diff/557610044/Documentation/music-glossary.tely File Documentation/music-glossary.tely (right): https://codereview.appspot.com/565750043/diff/557610044/Documentation/music-glossary.tely#newcode415 Documentation/music-glossary.tely:415: * transition arrow:: I think ...
4 months ago (2020-03-11 07:21:04 UTC) #19
davidsg
On 2020/03/11 02:30:04, Dan Eble wrote: > How about calling it a gradual-vowel-change-event? Come > ...
4 months ago (2020-03-11 09:08:25 UTC) #20
lemzwerg
> Gould talks specifically about vowels, but I don't see > any reason why it ...
4 months ago (2020-03-11 10:15:04 UTC) #21
davidsg
Rename to vowel-transition-event
4 months ago (2020-03-12 12:06:06 UTC) #22
davidsg
On 2020/03/12 12:06:06, davidsg wrote: > Rename to vowel-transition-event Trying again with the name 'vowel ...
4 months ago (2020-03-12 12:08:03 UTC) #23
lemzwerg
LGTM now, thanks! https://codereview.appspot.com/565750043/diff/557620047/scm/define-music-types.scm File scm/define-music-types.scm (right): https://codereview.appspot.com/565750043/diff/557620047/scm/define-music-types.scm#newcode685 scm/define-music-types.scm:685: . ((description . "A transition between ...
4 months ago (2020-03-12 17:38:06 UTC) #24
davidsg
Corrected VowelTransitionEvent description
4 months ago (2020-03-13 13:48:10 UTC) #25
davidsg
https://codereview.appspot.com/565750043/diff/557620047/scm/define-music-types.scm File scm/define-music-types.scm (right): https://codereview.appspot.com/565750043/diff/557620047/scm/define-music-types.scm#newcode685 scm/define-music-types.scm:685: . ((description . "A transition between lyric syllables.") On ...
4 months ago (2020-03-13 13:50:22 UTC) #26
davidsg
Added check to prevent issue if some bounds properties were not available.
3 months, 4 weeks ago (2020-03-14 07:44:19 UTC) #27
davidsg
Replaced property 'minimum-length-includes-padding' with 'minimum-length-correction'.
3 months, 4 weeks ago (2020-03-15 04:50:20 UTC) #28
hanwenn
https://codereview.appspot.com/565750043/diff/553710043/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/565750043/diff/553710043/Documentation/notation/vocal.itely#newcode894 Documentation/notation/vocal.itely:894: ah \vowelTransition _ _ _ _ is it vowel ...
3 months, 3 weeks ago (2020-03-15 15:00:50 UTC) #29
hanwenn
I tried looking at your patch, but: branch 'issue565750043_553710043' set up to track remote branch ...
3 months, 3 weeks ago (2020-03-15 15:10:36 UTC) #30
davidsg
Rebased on top of current master.
3 months, 3 weeks ago (2020-03-15 15:56:49 UTC) #31
davidsg
Revisions following review
3 months, 3 weeks ago (2020-03-20 11:37:44 UTC) #32
davidsg
Revisions following review https://codereview.appspot.com/565750043/diff/553710043/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/565750043/diff/553710043/Documentation/notation/vocal.itely#newcode894 Documentation/notation/vocal.itely:894: ah \vowelTransition _ _ _ _ ...
3 months, 3 weeks ago (2020-03-20 11:48:02 UTC) #33
hanwenn
LGTM Can you verify that the patch description is correct? The current version doesn't use ...
3 months, 2 weeks ago (2020-03-24 21:46:30 UTC) #34
davidsg
Corrections following review.
3 months, 2 weeks ago (2020-03-25 08:31:26 UTC) #35
davidsg
Restored accidentally deleted empty line.
3 months, 2 weeks ago (2020-03-25 08:38:23 UTC) #36
davidsg
Apologies for the noise for the last two patch sets.
3 months, 2 weeks ago (2020-03-25 08:43:25 UTC) #37
davidsg
Patch description in the issue tracker has been updated. https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc File lily/vowel-transition.cc (right): https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc#newcode37 lily/vowel-transition.cc:37: ...
3 months, 2 weeks ago (2020-03-25 08:45:31 UTC) #38
hanwenn
3 months, 2 weeks ago (2020-03-27 20:22:28 UTC) #39
On 2020/03/25 08:45:31, davidsg wrote:
> Patch description in the issue tracker has been updated.
> 
>
https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc
> File lily/vowel-transition.cc (right):
> 
>
https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition...
> lily/vowel-transition.cc:37: SCM num_length = me->get_property
> ("minimum-length");
> On 2020/03/24 21:46:30, hanwenn wrote:
> > num suggests a number.
> > 
> > minimum_length ?
> 
> Done.
> 
>
https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition...
> lily/vowel-transition.cc:137: w += -d * r->item_drul_[d]->extent
> (r->item_drul_[d], X_AXIS)[-d];
> On 2020/03/24 21:46:29, hanwenn wrote:
> > this still looks strange, but if it's problem, it'll be contained within the
> > vowel-transition code, which is acceptable.
> 
> Acknowledged, thanks.

this went into master. Can you close the review?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b