Issue 565610043: Issue 5705: Avoid warning in Stem::get_beaming ()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 565610043: Issue 5705: Avoid warning in Stem::get_beaming () (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 2 months ago by Dan Eble

Modified:
4 years, 2 months ago

Reviewers:
hanwenn

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

https://sourceforge.net/p/testlilyissues/issues/5705/

Patch Set 2 : implement suggestions #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	lily/stem.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hanwenn

LGTM thanks! https://codereview.appspot.com/565610043/diff/559450051/lily/stem.cc File lily/stem.cc (right): https://codereview.appspot.com/565610043/diff/559450051/lily/stem.cc#newcode99 lily/stem.cc:99: // we confident that the list is ...

4 years, 2 months ago (2020-02-03 22:11:10 UTC) #1

Dan Eble

In the review for the first attempt, David wrote: > It's probably more an academical ...

4 years, 2 months ago (2020-02-03 22:15:53 UTC) #2

implement suggestions

Expand All Messages | Collapse All Messages