Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1580)

Issue 5654081: store: do not log events internally on Publish

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by niemeyer
Modified:
12 years, 3 months ago
Reviewers:
mp+92811
Visibility:
Public.

Description

The external code that calls Publish has to deal with event logging anyway for logging failures and whatnot. It's trivial for it to log the error and success case from Publish too, so there's no reason to have that logic duplicated in two different places. In fact, it's harder to deal with it because the call site has to take care not to log errors twice in that particular case. https://code.launchpad.net/~niemeyer/juju/no-events-on-publish/+merge/92811 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : store: do not log events internally on Publish #

Patch Set 3 : store: do not log events internally on Publish #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -51 lines) Patch
M store/store.go View 1 3 chunks +6 lines, -21 lines 0 comments Download
M store/store_test.go View 1 2 chunks +4 lines, -30 lines 0 comments Download

Messages

Total messages: 5
niemeyer
Please take a look.
12 years, 3 months ago (2012-02-13 17:57:08 UTC) #1
rog
On 2012/02/13 17:57:08, niemeyer wrote: > Please take a look. LGTM
12 years, 3 months ago (2012-02-13 17:59:45 UTC) #2
niemeyer
Please take a look.
12 years, 3 months ago (2012-02-13 18:00:41 UTC) #3
fwereade
LGTM
12 years, 3 months ago (2012-02-13 18:03:31 UTC) #4
niemeyer
12 years, 3 months ago (2012-02-13 18:07:37 UTC) #5
*** Submitted:

store: do not log events internally on Publish

The external code that calls Publish has to deal with event logging
anyway for logging failures and whatnot. It's trivial for it to log the
error and success case from Publish too, so there's no reason to have
that logic duplicated in two different places. In fact, it's harder to
deal with it because the call site has to take care not to log errors
twice in that particular case.

R=rog, fwereade
CC=
https://codereview.appspot.com/5654081
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b