Issue 5583: www_post.py: don't mirror regtest baseline

https://sourceforge.net/p/testlilyissues/issues/5583/

I ran into a problem running "make ... doc" today, where www_post was trying unsuccessfully to mirror a symlink in an out-test-baseline subdirectory.

I looked around for information that would justify mirroring the baseline and found none, so I've solved the problem by excluding it.  If you know better, please speak up.

[pkx166h_runbox.com, 2019-10-23 16:12:06]

Hello,

On Wed, 23 Oct 2019 06:39:24 -0700, nine.fierce.ballads@gmail.com wrote:

> Reviewers: ,
> 
> Description:
> https://sourceforge.net/p/testlilyissues/issues/5583/
> 
> I ran into a problem running "make ... doc" today, where www_post was
> trying unsuccessfully to mirror a symlink in an out-test-baseline
> subdirectory.

OK good, it wasn't just me. I hit this today but as I am at work I didn't get
time to look and was planning this evening.

I am not sure which commit this was but normally we should revert it right? NOt
just patch over it in master?

James

[dak, 2019-10-23 16:36:41]

"James Lowe" <pkx166h@runbox.com> writes:

> Hello,
>
> On Wed, 23 Oct 2019 06:39:24 -0700, nine.fierce.ballads@gmail.com wrote:
>
>> Reviewers: ,
>> 
>> Description:
>> https://sourceforge.net/p/testlilyissues/issues/5583/
>> 
>> I ran into a problem running "make ... doc" today, where www_post was
>> trying unsuccessfully to mirror a symlink in an out-test-baseline
>> subdirectory.
>
> OK good, it wasn't just me. I hit this today but as I am at work I
> didn't get time to look and was planning this evening.
>
> I am not sure which commit this was but normally we should revert it
> right? NOt just patch over it in master?

Fixes should always be to staging rather than master but I guess that's
what you meant.  It depends on just how old the problem is whether one
tries to hotfix it.

-- 
David Kastrup

[dan_faithful.be, 2019-10-23 16:46:01]

> On Oct 23, 2019, at 12:36, David Kastrup <dak@gnu.org> wrote:
> 
> "James Lowe" <pkx166h@runbox.com> writes:
> 
> Fixes should always be to staging rather than master but I guess that's
> what you meant.  It depends on just how old the problem is whether one
> tries to hotfix it.

Baselines created after this commit (a few back from the current tip of master)
will create out-test-baseline/share as a symlink.

    0d7744aad0 Issue 5572/1: Compile modified C++ files automatically before
testing
— 
Dan

[dak, 2019-10-23 16:51:52]

Dan Eble <dan@faithful.be> writes:

>> On Oct 23, 2019, at 12:36, David Kastrup <dak@gnu.org> wrote:
>> 
>> "James Lowe" <pkx166h@runbox.com> writes:
>> 
>> Fixes should always be to staging rather than master but I guess that's
>> what you meant.  It depends on just how old the problem is whether one
>> tries to hotfix it.
>
> Baselines created after this commit (a few back from the current tip
> of master) will create out-test-baseline/share as a symlink.
>
>     0d7744aad0 Issue 5572/1: Compile modified C++ files automatically before
testing
> — 
> Dan

I've no qualified opinion about this one.  If you think it's messing up
current testing, feel free to push the fix to staging without waiting
for count-down etc (I doubt there will be much further feedback) if you
are reasonably confident that this will address it.

-- 
David Kastrup