Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 5650075: Add some comments to Event and Stat types.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by rog
Modified:
10 years, 4 months ago
Reviewers:
mp+92750
Visibility:
Public.

Description

Also change Stat.CTime and Stat.MTime to return time.Time. https://code.launchpad.net/~rogpeppe/gozk/comments-and-time/+merge/92750 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 9

Patch Set 2 : Add some comments to Event and Stat types. #

Patch Set 3 : Add some comments to Event and Stat types. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -14 lines) Patch
M zk.go View 1 2 chunks +30 lines, -11 lines 0 comments Download
M zk_test.go View 1 2 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 6
rog
Please take a look.
10 years, 4 months ago (2012-02-13 12:39:21 UTC) #1
niemeyer
https://codereview.appspot.com/5650075/diff/1/zk.go File zk.go (right): https://codereview.appspot.com/5650075/diff/1/zk.go#newcode97 zk.go:97: // event. This is extremely redundant. Please use something ...
10 years, 4 months ago (2012-02-13 13:53:57 UTC) #2
rog
Please take a look.
10 years, 4 months ago (2012-02-13 14:48:12 UTC) #3
rog
PTAL https://codereview.appspot.com/5650075/diff/1/zk.go File zk.go (right): https://codereview.appspot.com/5650075/diff/1/zk.go#newcode97 zk.go:97: // event. On 2012/02/13 13:53:57, niemeyer wrote: > ...
10 years, 4 months ago (2012-02-13 14:48:27 UTC) #4
niemeyer
LGTM
10 years, 4 months ago (2012-02-13 14:52:09 UTC) #5
rog
10 years, 4 months ago (2012-02-13 14:54:12 UTC) #6
*** Submitted:

Add some comments to Event and Stat types.

Also change Stat.CTime and Stat.MTime to return time.Time.

R=niemeyer
CC=
https://codereview.appspot.com/5650075
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b