Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 5650071: code review 5650071: net: avoid TCP self-connect (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by rsc
Modified:
7 years, 6 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

net: avoid TCP self-connect Fixes issue 2690.

Patch Set 1 #

Patch Set 2 : diff -r 4a0c77722a5e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8296cf56b8c1 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 3242e3c73955 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M src/pkg/net/dial_test.go View 1 1 chunk +31 lines, -0 lines 0 comments Download
M src/pkg/net/tcpsock_posix.go View 1 2 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 6 months ago (2012-02-13 03:32:50 UTC) #1
bradfitz
LGTM http://codereview.appspot.com/5650071/diff/4001/src/pkg/net/dial_test.go File src/pkg/net/dial_test.go (right): http://codereview.appspot.com/5650071/diff/4001/src/pkg/net/dial_test.go#newcode88 src/pkg/net/dial_test.go:88: func TestSelfConnect(t *testing.T) { I assume you were ...
7 years, 6 months ago (2012-02-13 03:54:52 UTC) #2
rsc
On Sun, Feb 12, 2012 at 22:54, <bradfitz@golang.org> wrote: > src/pkg/net/dial_test.go:88: func TestSelfConnect(t *testing.T) { ...
7 years, 6 months ago (2012-02-13 04:23:43 UTC) #3
rsc
7 years, 6 months ago (2012-02-13 04:25:58 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=002f08814913 ***

net: avoid TCP self-connect

Fixes issue 2690.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5650071
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b