Code review - Issue 5650071: code review 5650071: net: avoid TCP self-connecthttps://codereview.appspot.com/2012-02-13T04:25:58+00:00rietveld
Message from unknown
2012-02-12T21:53:52+00:00rscurn:md5:547b1820b7393e9a9091a106946a6260
Message from unknown
2012-02-12T21:54:23+00:00rscurn:md5:90a255ecdf95a617c9f090357876f0e3
Message from unknown
2012-02-13T03:32:46+00:00rscurn:md5:8ccc49cc6a2f82057ff192815e2aa8de
Message from rsc@golang.org
2012-02-13T03:32:50+00:00rscurn:md5:b3e2d2c1c85486623a6fd3c80bb44be0
Hello golang-dev@googlegroups.com,
I'd like you to review this change to
https://go.googlecode.com/hg/
Message from bradfitz@golang.org
2012-02-13T03:54:52+00:00bradfitzurn:md5:a6316119241c0e9c7c26385dbd4e92d6
LGTM
http://codereview.appspot.com/5650071/diff/4001/src/pkg/net/dial_test.go
File src/pkg/net/dial_test.go (right):
http://codereview.appspot.com/5650071/diff/4001/src/pkg/net/dial_test.go#newcode88
src/pkg/net/dial_test.go:88: func TestSelfConnect(t *testing.T) {
I assume you were able to make this fail before?
http://codereview.appspot.com/5650071/diff/4001/src/pkg/net/sendfile_linux.go
File src/pkg/net/sendfile_linux.go (right):
http://codereview.appspot.com/5650071/diff/4001/src/pkg/net/sendfile_linux.go#newcode60
src/pkg/net/sendfile_linux.go:60: if err1 = pollserver.WaitWrite(c); err1 == nil {
this seems correct, but unrelated to this CL
Message from rsc@golang.org
2012-02-13T04:23:43+00:00rscurn:md5:53d70beb8b709e91c64b13cb6b269130
On Sun, Feb 12, 2012 at 22:54, <bradfitz@golang.org> wrote:
> src/pkg/net/dial_test.go:88: func TestSelfConnect(t *testing.T) {
> I assume you were able to make this fail before?
Yes. It's pretty easy but takes about 2 seconds (long mode).
The sendfile_linux.go is misfiled; thanks for catching that.
Russ
Message from unknown
2012-02-13T04:25:52+00:00rscurn:md5:c62e3ccd00986a813fccca4d9a1c97ed
Message from rsc@golang.org
2012-02-13T04:25:58+00:00rscurn:md5:f4da08a13e317e6ce6e82448c71dfd79
*** Submitted as http://code.google.com/p/go/source/detail?r=002f08814913 ***
net: avoid TCP self-connect
Fixes issue 2690.
R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5650071