Issue 5650069: code review 5650069: runtime: delete Type and implementations (use reflect i...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5650069: code review 5650069: runtime: delete Type and implementations (use reflect i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by rsc

Modified:
12 years, 7 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

runtime: delete Type and implementations (use reflect instead) unsafe: delete Typeof, Reflect, Unreflect, New, NewArray Part of issue 2955 and issue 2968.

Patch Set 2 : diff -r 8296cf56b8c1 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 3 : diff -r 002f08814913 https://go.googlecode.com/hg/ #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -509 lines)			Patch
M	src/cmd/gc/go.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/lex.c	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/gc/reflect.c	View	1	3 chunks	+11 lines, -55 lines	0 comments	Download
M	src/cmd/ld/dwarf.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/encoding/gob/decode.go	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/encoding/gob/encode.go	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/reflect/type.go	View	1 2	7 chunks	+71 lines, -75 lines	0 comments	Download
M	src/pkg/reflect/value.go	View	1	7 chunks	+25 lines, -14 lines	0 comments	Download
M	src/pkg/runtime/error.go	View	1	4 chunks	+3 lines, -36 lines	0 comments	Download
M	src/pkg/runtime/iface.c	View	1	17 chunks	+12 lines, -108 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/type.go	View	1	1 chunk	+30 lines, -185 lines	0 comments	Download
M	src/pkg/unsafe/unsafe.go	View	1	1 chunk	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 7 months ago (2012-02-13 03:33:02 UTC) #1

LGTM http://codereview.appspot.com/5650069/diff/2001/src/pkg/reflect/type.go File src/pkg/reflect/type.go (right): http://codereview.appspot.com/5650069/diff/2001/src/pkg/reflect/type.go#newcode241 src/pkg/reflect/type.go:241: _ uint8 // unused s/unused/padding/? http://codereview.appspot.com/5650069/diff/2001/src/pkg/reflect/type.go#newcode252 src/pkg/reflect/type.go:252: type ...

12 years, 7 months ago (2012-02-13 03:46:53 UTC) #2

rsc

On Sun, Feb 12, 2012 at 22:46, <r@golang.org> wrote: > what underscore? it's gone.

12 years, 7 months ago (2012-02-13 04:21:02 UTC) #3

rsc

12 years, 7 months ago (2012-02-13 04:26:24 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=2646dc956207 ***

runtime: delete Type and implementations (use reflect instead)
unsafe: delete Typeof, Reflect, Unreflect, New, NewArray

Part of issue 2955 and issue 2968.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5650069

Expand All Messages | Collapse All Messages