Code review - Issue 5650069: code review 5650069: runtime: delete Type and implementations (use reflect i...https://codereview.appspot.com/2012-02-13T04:26:24+00:00rietveld
Message from unknown
2012-02-12T19:26:38+00:00rscurn:md5:61d71a43975eb7368168e675cc6d2615
Message from unknown
2012-02-13T03:32:56+00:00rscurn:md5:702c07333a102d6d7773bf534255e048
Message from rsc@golang.org
2012-02-13T03:33:02+00:00rscurn:md5:7cdb37a19bbaa401bb8f732cae23b4e7
Hello golang-dev@googlegroups.com,
I'd like you to review this change to
https://go.googlecode.com/hg/
Message from r@golang.org
2012-02-13T03:46:53+00:00rurn:md5:c919395cd17fd04d642189e4fd1daedf
LGTM
http://codereview.appspot.com/5650069/diff/2001/src/pkg/reflect/type.go
File src/pkg/reflect/type.go (right):
http://codereview.appspot.com/5650069/diff/2001/src/pkg/reflect/type.go#newcode241
src/pkg/reflect/type.go:241: _ uint8 // unused
s/unused/padding/?
http://codereview.appspot.com/5650069/diff/2001/src/pkg/reflect/type.go#newcode252
src/pkg/reflect/type.go:252: type method struct { // underscore is to avoid collision with C
what underscore?
Message from rsc@golang.org
2012-02-13T04:21:02+00:00rscurn:md5:d9599291649edba777a118f74bbd054d
On Sun, Feb 12, 2012 at 22:46, <r@golang.org> wrote:
> what underscore?
it's gone.
Message from unknown
2012-02-13T04:26:15+00:00rscurn:md5:88a8b1db52d5a94a40290f9d6d3a92fe
Message from rsc@golang.org
2012-02-13T04:26:24+00:00rscurn:md5:e443e5ff0f01600c68c9c3cd156c33ab
*** Submitted as http://code.google.com/p/go/source/detail?r=2646dc956207 ***
runtime: delete Type and implementations (use reflect instead)
unsafe: delete Typeof, Reflect, Unreflect, New, NewArray
Part of issue 2955 and issue 2968.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5650069