Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(675)

Issue 5647069: Remove Cajita and debug source spans rendering. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by ihab.awad
Modified:
14 years, 4 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Remove Cajita and debug source spans rendering. #

Patch Set 3 : Remove Cajita and debug source spans rendering. #

Total comments: 2

Patch Set 4 : Remove Cajita and debug source spans rendering. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -4069 lines) Patch
M build.xml View 4 chunks +0 lines, -4 lines 0 comments Download
D src/com/google/caja/cajita-module-orig.js View 1 chunk +0 lines, -328 lines 0 comments Download
M src/com/google/caja/parser/AbstractParseTreeNode.java View 1 chunk +0 lines, -2 lines 0 comments Download
M src/com/google/caja/parser/ParseTreeNodeContainer.java View 1 chunk +1 line, -3 lines 0 comments Download
M src/com/google/caja/parser/js/CajoledModule.java View 3 chunks +0 lines, -209 lines 0 comments Download
M src/com/google/caja/parser/js/ObjectConstructor.java View 2 chunks +5 lines, -3 lines 0 comments Download
M src/com/google/caja/parser/js/SyntheticNodes.java View 1 chunk +0 lines, -1 line 0 comments Download
D src/com/google/caja/parser/quasiliteral/CajitaModuleRewriter.java View 1 chunk +0 lines, -114 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/CajitaRewriter.java View 1 chunk +0 lines, -2350 lines 0 comments Download
M src/com/google/caja/parser/quasiliteral/ES53Rewriter.java View 6 chunks +5 lines, -9 lines 0 comments Download
M src/com/google/caja/parser/quasiliteral/ModuleManager.java View 3 chunks +1 line, -5 lines 0 comments Download
A + src/com/google/caja/parser/quasiliteral/ModuleRewriter.java View 3 chunks +8 lines, -8 lines 0 comments Download
M src/com/google/caja/parser/quasiliteral/RewriterMessageType.java View 1 chunk +3 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/quasiliteral/RuleDescription.java View 1 chunk +0 lines, -3 lines 0 comments Download
M src/com/google/caja/parser/quasiliteral/TextRuleDoclet.java View 2 chunks +2 lines, -2 lines 0 comments Download
M src/com/google/caja/plugin/Config.java View 1 chunk +0 lines, -1 line 0 comments Download
M src/com/google/caja/plugin/PluginCompiler.java View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/plugin/PluginCompilerMain.java View 1 2 3 5 chunks +1 line, -28 lines 0 comments Download
M src/com/google/caja/plugin/stages/ConsolidateCodeStage.java View 2 chunks +2 lines, -2 lines 0 comments Download
M src/com/google/caja/precajole/PrecajoleTask.java View 1 chunk +1 line, -1 line 0 comments Download
D src/com/google/caja/render/SourceSpansRenderer.java View 1 chunk +0 lines, -335 lines 0 comments Download
M src/com/google/caja/service/CajolingService.java View 1 2 chunks +0 lines, -2 lines 0 comments Download
D src/com/google/caja/service/InnocentHandler.java View 1 chunk +0 lines, -105 lines 0 comments Download
M tests/com/google/caja/lang/css/CssSchemaTest.java View 2 chunks +13 lines, -1 line 0 comments Download
M tests/com/google/caja/parser/html/DomMembrane.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/parser/quasiliteral/ES53RewriterTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/parser/quasiliteral/ModuleFormatTest.java View 4 chunks +5 lines, -75 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/RewriterTestCase.java View 2 chunks +2 lines, -4 lines 0 comments Download
D tests/com/google/caja/parser/quasiliteral/testModule.out.js View 1 chunk +0 lines, -37 lines 0 comments Download
D tests/com/google/caja/plugin/ES53BrowserTest.java View 1 chunk +0 lines, -205 lines 0 comments Download
M tests/com/google/caja/plugin/ExpressionSanitizerTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + tests/com/google/caja/plugin/GeneralBrowserTest.java View 1 chunk +1 line, -4 lines 0 comments Download
M tests/com/google/caja/plugin/PipelineCacheTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M tests/com/google/caja/plugin/PipelineMakerTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/plugin/browser-test-case.html View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/com/google/caja/plugin/stages/OptimizeJavascriptStageTest.java View 1 chunk +1 line, -1 line 0 comments Download
D tests/com/google/caja/render/SourceSpansRendererTest.java View 1 chunk +0 lines, -79 lines 0 comments Download
D tests/com/google/caja/render/ssp-golden.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/com/google/caja/render/ssp-rewritten-tokens.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/com/google/caja/render/ssp-test-input.js View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/com/google/caja/service/InnocentHandlerTest.java View 1 chunk +0 lines, -92 lines 0 comments Download

Messages

Total messages: 7
ihab.awad
14 years, 4 months ago (2012-02-14 19:27:37 UTC) #1
ihab.awad
14 years, 4 months ago (2012-02-14 19:33:33 UTC) #2
felix8a
lgtm++ http://codereview.appspot.com/5647069/diff/2001/src/com/google/caja/plugin/PluginCompilerMain.java File src/com/google/caja/plugin/PluginCompilerMain.java (left): http://codereview.appspot.com/5647069/diff/2001/src/com/google/caja/plugin/PluginCompilerMain.java#oldcode397 src/com/google/caja/plugin/PluginCompilerMain.java:397: originalInputs.put(is, cr); also delete declaration of originalInputs. I ...
14 years, 4 months ago (2012-02-14 21:26:46 UTC) #3
ihab.awad
http://codereview.appspot.com/5647069/diff/2001/src/com/google/caja/plugin/PluginCompilerMain.java File src/com/google/caja/plugin/PluginCompilerMain.java (left): http://codereview.appspot.com/5647069/diff/2001/src/com/google/caja/plugin/PluginCompilerMain.java#oldcode397 src/com/google/caja/plugin/PluginCompilerMain.java:397: originalInputs.put(is, cr); On 2012/02/14 21:26:46, felix8a wrote: > also ...
14 years, 4 months ago (2012-02-14 21:42:23 UTC) #4
ihab.awad
14 years, 4 months ago (2012-02-14 21:44:24 UTC) #5
felix8a
lgtm
14 years, 4 months ago (2012-02-14 22:10:08 UTC) #6
ihab.awad
14 years, 4 months ago (2012-02-14 22:48:09 UTC) #7
@4780
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b