Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in

Issue 5647044: Cancel button in music library - issue 647

Can't Edit
Can't Publish+Mail
Start Review
11 years, 7 months ago by vasilakisfil
1 year, 4 months ago
Alan Briolat


Cancel button in music library - issue 647

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1 line) Patch
M src/library/librarysettingspage.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/library/librarysettingspage.cpp View 4 chunks +57 lines, -1 line 0 comments Download


Total messages: 1
Alan Briolat
11 years, 7 months ago (2012-02-07 21:48:19 UTC) #1
I like how this patch tries to be fairly non-invasive to the existing code, but
there is one big problem that isn't addressed: library scanning starts
immediately after you add the directory, not when you click "OK".  Therefore
when you add a directory it starts scanning and adding all the tracks, and then
when you click cancel it removes them again.

I feel it might be cleaner to actually decouple the list view from the
LibraryDirectoryModel.  If you have a separate QStandardItemModel with just the
path strings in it, on "Cancel" you can continue to act as if nothing happened,
and on "OK" you can synchronise the two models.  (Basically the opposite to what
this patch does.)  This would make sure that your library is completely
unchanged until you actually hit "OK".
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b