Issue 5647044: Cancel button in music library - issue 647

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5647044: Cancel button in music library - issue 647

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by vasilakisfil

Modified:
1 year, 11 months ago

Reviewers:
Alan Briolat

Visibility:
Public.

More Reviews

Description

Cancel button in music library - issue 647

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -1 line)			Patch
	M	src/library/librarysettingspage.h	View		3 chunks	+3 lines, -0 lines	0 comments	Download
	M	src/library/librarysettingspage.cpp	View		4 chunks	+57 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Alan Briolat

12 years, 3 months ago (2012-02-07 21:48:19 UTC) #1

I like how this patch tries to be fairly non-invasive to the existing code, but
there is one big problem that isn't addressed: library scanning starts
immediately after you add the directory, not when you click "OK".  Therefore
when you add a directory it starts scanning and adding all the tracks, and then
when you click cancel it removes them again.

I feel it might be cleaner to actually decouple the list view from the
LibraryDirectoryModel.  If you have a separate QStandardItemModel with just the
path strings in it, on "Cancel" you can continue to act as if nothing happened,
and on "OK" you can synchronise the two models.  (Basically the opposite to what
this patch does.)  This would make sure that your library is completely
unchanged until you actually hit "OK".

Expand All Messages | Collapse All Messages