Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(239)

Issue 5645051: code review 5645051: archive/zip: tweak API and docs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by adg
Modified:
9 years, 10 months ago
Reviewers:
CC:
golang-dev, niemeyer, r, bradfitz
Visibility:
Public.

Description

archive/zip: tweak API and docs. Fixes issue 2835.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 73a4a2506d41 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 37a5f3ad9990 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/pkg/archive/zip/reader.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/archive/zip/writer.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
9 years, 10 months ago (2012-02-08 03:21:26 UTC) #1
niemeyer
http://codereview.appspot.com/5645051/diff/1/src/pkg/archive/zip/reader.go File src/pkg/archive/zip/reader.go (right): http://codereview.appspot.com/5645051/diff/1/src/pkg/archive/zip/reader.go#newcode120 src/pkg/archive/zip/reader.go:120: // Files may be Opened and and Read from ...
9 years, 10 months ago (2012-02-08 03:26:34 UTC) #2
adg
On 8 February 2012 14:26, <n13m3y3r@gmail.com> wrote: > > http://codereview.appspot.com/5645051/diff/1/src/pkg/archive/zip/reader.go > File src/pkg/archive/zip/reader.go (right): > ...
9 years, 10 months ago (2012-02-08 03:28:08 UTC) #3
r
http://codereview.appspot.com/5645051/diff/1/src/pkg/archive/zip/reader.go File src/pkg/archive/zip/reader.go (right): http://codereview.appspot.com/5645051/diff/1/src/pkg/archive/zip/reader.go#newcode120 src/pkg/archive/zip/reader.go:120: // Files may be Opened and and Read from ...
9 years, 10 months ago (2012-02-08 03:30:36 UTC) #4
r
LGTM
9 years, 10 months ago (2012-02-08 03:30:58 UTC) #5
bradfitz
I think the original confusion was about what it was concurrent to. I think I ...
9 years, 10 months ago (2012-02-08 03:31:08 UTC) #6
adg
Hello golang-dev@googlegroups.com, n13m3y3r@gmail.com, r@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 10 months ago (2012-02-08 03:33:15 UTC) #7
adg
9 years, 10 months ago (2012-02-08 03:34:46 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=1ca43e8ce166 ***

archive/zip: tweak API and docs.

Fixes issue 2835.

R=golang-dev, n13m3y3r, r, bradfitz
CC=golang-dev
http://codereview.appspot.com/5645051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b