code review 5645051: archive/zip: tweak API and docs.

archive/zip: tweak API and docs.

Fixes issue 2835.

[adg, 2012-02-08 03:21:26]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[niemeyer, 2012-02-08 03:26:34]

http://codereview.appspot.com/5645051/diff/1/src/pkg/archive/zip/reader.go
File src/pkg/archive/zip/reader.go (right):

http://codereview.appspot.com/5645051/diff/1/src/pkg/archive/zip/reader.go#ne...
src/pkg/archive/zip/reader.go:120: // Files may be Opened and and Read from
concurrently.
It might be just me, but the original version reads slightly more easily.

[adg, 2012-02-08 03:28:08]

On 8 February 2012 14:26,  <n13m3y3r@gmail.com> wrote:
>
> http://codereview.appspot.com/5645051/diff/1/src/pkg/archive/zip/reader.go
> File src/pkg/archive/zip/reader.go (right):
>
>
http://codereview.appspot.com/5645051/diff/1/src/pkg/archive/zip/reader.go#ne...
> src/pkg/archive/zip/reader.go:120: // Files may be Opened and and Read
> from concurrently.
> It might be just me, but the original version reads slightly more
> easily.

Yeah I guess so. Russ said he didn't understand. I'm open to suggestions.

[r, 2012-02-08 03:30:36]

http://codereview.appspot.com/5645051/diff/1/src/pkg/archive/zip/reader.go
File src/pkg/archive/zip/reader.go (right):

http://codereview.appspot.com/5645051/diff/1/src/pkg/archive/zip/reader.go#ne...
src/pkg/archive/zip/reader.go:120: // Files may be Opened and and Read from
concurrently.
agree. also the capitals are unnecessary.

[r, 2012-02-08 03:30:58]

LGTM

[bradfitz, 2012-02-08 03:31:08]

I think the original confusion was about what it was concurrent to.

I think I was the one who bugged you to add some docs on this, but I can't
remember what my original fear was--- was it that archive/zip wasn't
originally safe to open/read *different files* concurrently before?  There
was some state that was moved around.

On Tue, Feb 7, 2012 at 7:27 PM, Andrew Gerrand <adg@golang.org> wrote:

> On 8 February 2012 14:26,  <n13m3y3r@gmail.com> wrote:
> >
> >
> http://codereview.appspot.com/5645051/diff/1/src/pkg/archive/zip/reader.go
> > File src/pkg/archive/zip/reader.go (right):
> >
> >
>
http://codereview.appspot.com/5645051/diff/1/src/pkg/archive/zip/reader.go#ne...
> > src/pkg/archive/zip/reader.go:120: // Files may be Opened and and Read
> > from concurrently.
> > It might be just me, but the original version reads slightly more
> > easily.
>
> Yeah I guess so. Russ said he didn't understand. I'm open to suggestions.
>

[adg, 2012-02-08 03:33:15]

Hello golang-dev@googlegroups.com, n13m3y3r@gmail.com, r@golang.org,
bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2012-02-08 03:34:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=1ca43e8ce166 ***

archive/zip: tweak API and docs.

Fixes issue 2835.

R=golang-dev, n13m3y3r, r, bradfitz
CC=golang-dev
http://codereview.appspot.com/5645051