Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(181)

Issue 56430043: code review 56430043: cmd/gc: add zeroing to enable precise stack accounting (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by rsc
Modified:
11 years, 5 months ago
Reviewers:
gobot, khr
CC:
iant, golang-codereviews
Visibility:
Public.

Description

cmd/gc: add zeroing to enable precise stack accounting There is more zeroing than I would like right now - temporaries used for the new map and channel runtime calls need to be eliminated - but it will do for now. This CL only has an effect if you are building with GOEXPERIMENT=precisestack ./all.bash (or make.bash). It costs about 5% in the overall time spent in all.bash. That number will come down before we make it on by default, but this should be enough for Keith to try using the precise maps for copying stacks. amd64 only (and it's not really great generated code).

Patch Set 1 #

Patch Set 2 : diff -r 6ef642823263 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6ef642823263 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -14 lines) Patch
M src/cmd/6g/ggen.c View 1 3 chunks +33 lines, -2 lines 0 comments Download
M src/cmd/gc/plive.c View 1 1 chunk +15 lines, -11 lines 0 comments Download
M src/pkg/runtime/mgc0.c View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello iant, khr (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 5 months ago (2014-01-24 04:11:00 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=7d1281494058 *** cmd/gc: add zeroing to enable precise stack accounting There is ...
11 years, 5 months ago (2014-01-24 04:11:07 UTC) #2
gobot
This CL appears to have broken the windows-amd64-race builder.
11 years, 5 months ago (2014-01-24 04:32:56 UTC) #3
khr
11 years, 5 months ago (2014-01-24 22:24:49 UTC) #4
Message was sent while issue was closed.
On 2014/01/24 04:32:56, gobot wrote:
> This CL appears to have broken the windows-amd64-race builder.

LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b