Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4441)

Issue 56420043: Added tavern support to Spark. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by pajamallama
Modified:
10 years, 3 months ago
Reviewers:
tapted
CC:
chrome-apps-internsyd_google.com
Base URL:
https://github.com/tapted/spark.git@master
Visibility:
Public.

Description

Added tavern support to Spark. Now when a pubspec.yaml file is selected inside a chrome app project (i.e. a directory which has a manifest.json file) then hitting the run button will download the selected dependencies. The tavern log output should also appear in a separate window. R=tapted@chromium.org Committed: https://github.com/tapted/bleeding_edge/commit/9600ba5

Patch Set 1 #

Patch Set 2 : Fixed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M ide/app/lib/launch.dart View 1 2 chunks +10 lines, -2 lines 0 comments Download
M ide/app/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M ide/app/spark_polymer.html View 1 chunk +5 lines, -0 lines 0 comments Download
A ide/codereview.settings View 1 chunk +3 lines, -0 lines 0 comments Download
M ide/pubspec.yaml View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
pajamallama
Spark support nom nom nom.
10 years, 3 months ago (2014-01-24 04:00:31 UTC) #1
tapted
crap. stupid rietveld. The base files are missing - can you re-upload?
10 years, 3 months ago (2014-01-24 06:14:34 UTC) #2
tapted
Actually looking at the diff in email (and variable width font :o), I think you ...
10 years, 3 months ago (2014-01-24 06:31:51 UTC) #3
pajamallama
10 years, 3 months ago (2014-01-28 00:01:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r9600ba5 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b