Allowing a HTML/JavaScript interface for Spark to use for logging.

Allowing a HTML/JavaScript interface for Spark to use for logging.

Now if the spark app's HTML includes "packages/tavern/tavern_log.js"
then it can pass "js.context.logMessage" to tavern.getDependencies as
and the log window will appear mirroring the log output.

Known bug to be fixed soon: multiple calls to getDependencies re-adds
the extra logging function so the nth call will show each log message
n times.

R=tapted@chromium.org

Committed: https://github.com/tapted/bleeding_edge/commit/4105976

[tapted, 2014-01-24 03:41:07]

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/jszip.js (right):

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/jszip.js:1: (function(e){if("function"==typeof
bootstrap)bootstrap("jszip",e);else if("object"==typeof
exports)module.exports=e();else if("function"==typeof
define&&define.amd)define(e);else if("undefined"!=typeof
ses){if(!ses.ok())return;ses.makeJSZip=e}else"undefined"!=typeof
window?window.JSZip=e():global.JSZip=e()})(function(){var
define,ses,bootstrap,module,exports;
shouldn't this be pulled in via git-submodules?

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/tavern_log.js (right):

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/tavern_log.js:2:
chrome.app.window.create("packages/tavern/tavern_log.html", {id: "tavern"},
nit: single quotes for literals in javascript, more below.

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/tavern_log.js:14: } else {
nit: we usually just do an early return (line above), and don't bother with the
`else`

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/tavern_log.js:15: var newMessage = "<div
class='log log_" +
nit: wrap like

    var newMessage =
        '<div class="log log_' + level + '">' + line + '</div>';

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/tavern_log.js:16: level + "'>" + line + "</div>";
*I think you'll need to escape `line` here in case it has html markup. (e.g.
what happens if someone logs "</div>")

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/tavern_log.js:18: if (logtext == null)
should this ever happen? I'd maybe just ignore the possibility and let JS throw
an exception

[pajamallama, 2014-01-24 05:16:17]

Fixed those JS nits & removed jszip.js from the repo (now a Makefile step).

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/jszip.js (right):

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/jszip.js:1: (function(e){if("function"==typeof
bootstrap)bootstrap("jszip",e);else if("object"==typeof
exports)module.exports=e();else if("function"==typeof
define&&define.amd)define(e);else if("undefined"!=typeof
ses){if(!ses.ok())return;ses.makeJSZip=e}else"undefined"!=typeof
window?window.JSZip=e():global.JSZip=e()})(function(){var
define,ses,bootstrap,module,exports;
On 2014/01/24 03:41:07, tapted wrote:
> shouldn't this be pulled in via git-submodules?

Done.

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/tavern_log.js (right):

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/tavern_log.js:2:
chrome.app.window.create("packages/tavern/tavern_log.html", {id: "tavern"},
On 2014/01/24 03:41:07, tapted wrote:
> nit: single quotes for literals in javascript, more below.

Done.

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/tavern_log.js:14: } else {
On 2014/01/24 03:41:07, tapted wrote:
> nit: we usually just do an early return (line above), and don't bother with
the
> `else`

Done.

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/tavern_log.js:15: var newMessage = "<div
class='log log_" +
On 2014/01/24 03:41:07, tapted wrote:
> nit: wrap like
> 
>     var newMessage =
>         '<div class="log log_' + level + '">' + line + '</div>';

Done.

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/tavern_log.js:16: level + "'>" + line + "</div>";
On 2014/01/24 03:41:07, tapted wrote:
> *I think you'll need to escape `line` here in case it has html markup. (e.g.
> what happens if someone logs "</div>")

Done.

https://codereview.appspot.com/56400043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/tavern_log.js:18: if (logtext == null)
On 2014/01/24 03:41:07, tapted wrote:
> should this ever happen? I'd maybe just ignore the possibility and let JS
throw
> an exception

Done.

[tapted, 2014-01-24 06:13:18]

lgtm

[pajamallama, 2014-01-27 22:58:45]

Committed patchset #4 manually as r4105976.