Issue 5639067: store: store a single charm for all its urls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5639067: store: store a single charm for all its urls

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by niemeyer

Modified:
12 years, 3 months ago

Reviewers:
mp+92193

Visibility:
Public.

Description

It's clear now that storing multiple charms just because they have a different URL is unnecessary. Also add index for events collection. https://code.launchpad.net/~niemeyer/juju/store-one-charm-only/+merge/92193 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : store: store a single charm for all its urls #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -25 lines)			Patch
	M	store/store.go	View		6 chunks	+28 lines, -25 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

On 2012/02/09 03:14:16, niemeyer wrote: > Please take a look. Reviews please?

12 years, 3 months ago (2012-02-10 13:04:26 UTC) #2

niemeyer

12 years, 3 months ago (2012-02-10 17:33:06 UTC) #5

*** Submitted:

store: store a single charm for all its urls

It's clear now that storing multiple charms just because
they have a different URL is unnecessary.

Also add index for events collection.

R=fwereade, rog
CC=
https://codereview.appspot.com/5639067

Expand All Messages | Collapse All Messages