Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1046)

Issue 563730043: Address output-distance problems: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by hanwenn
Modified:
3 months, 3 weeks ago
Reviewers:
dak, barrykp, dan, hahnjo, hahnjo, pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Address output-distance problems: * Run output-distance.py from srcdir * Fix <meta charset=".."> tag * Generate self-test HTML in out/ * Remove test files afterwards

Patch Set 1 #

Patch Set 2 : local-test #

Total comments: 1

Patch Set 3 : meta #

Patch Set 4 : disable test #

Patch Set 5 : disable test (try 2) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M scripts/build/GNUmakefile View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/build/output-distance.py View 1 2 2 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 35
hanwenn
local-test
4 months ago (2020-03-11 11:48:23 UTC) #1
hahnjo
Looks mostly good to me, but I don't understand the change for <meta>. I'd propose ...
4 months ago (2020-03-11 12:15:54 UTC) #2
hanwenn
On 2020/03/11 12:15:54, hahnjo wrote: > Looks mostly good to me, but I don't understand ...
4 months ago (2020-03-11 19:59:47 UTC) #3
hanwenn
meta
4 months ago (2020-03-11 19:59:58 UTC) #4
hahnjo
LGTM (It might be a good idea to suppress the output of the test run ...
4 months ago (2020-03-11 21:00:26 UTC) #5
hanwenn
going to fast-track this so the testing can continue.
4 months ago (2020-03-11 21:44:41 UTC) #6
dak
hanwenn@gmail.com writes: > going to fast-track this so the testing can continue. > > https://codereview.appspot.com/563730043/ ...
4 months ago (2020-03-11 23:49:23 UTC) #7
hanwenn
Easiest fix is probably to change disable the test for output-distance, by backing out the ...
4 months ago (2020-03-12 00:11:02 UTC) #8
hahnjo
On 2020/03/11 23:49:23, dak wrote: > [...] > GNU LilyPond 2.21.0 > cp: cannot stat ...
4 months ago (2020-03-12 08:01:03 UTC) #9
hanwenn
disable test
4 months ago (2020-03-12 08:46:02 UTC) #10
hanwenn
disable test (try 2)
4 months ago (2020-03-12 08:47:16 UTC) #11
dak
On 2020/03/12 08:01:03, hahnjo wrote: > On 2020/03/11 23:49:23, dak wrote: > > [...] > ...
4 months ago (2020-03-12 09:22:09 UTC) #12
hahnjo
On 2020/03/12 09:22:09, dak wrote: > On 2020/03/12 08:01:03, hahnjo wrote: > > This looks ...
4 months ago (2020-03-12 09:33:43 UTC) #13
pkx166h_posteo.net
Hello What exactly am I supposed to be testing? With or without make check? I ...
4 months ago (2020-03-12 09:36:54 UTC) #14
hahnjo
On 2020/03/12 09:33:43, hahnjo wrote: > On 2020/03/12 09:22:09, dak wrote: > > On 2020/03/12 ...
4 months ago (2020-03-12 09:52:31 UTC) #15
dak
On 2020/03/12 09:52:31, hahnjo wrote: > On 2020/03/12 09:33:43, hahnjo wrote: > > On 2020/03/12 ...
4 months ago (2020-03-12 10:03:22 UTC) #16
hahnjo
On 2020/03/12 10:03:22, dak wrote: > Patch needs work (whether it contains a problem itself ...
4 months ago (2020-03-12 10:10:23 UTC) #17
hanwenn
On Thu, Mar 12, 2020 at 10:37 AM <pkx166h@posteo.net> wrote: > > Hello > > ...
4 months ago (2020-03-12 10:32:16 UTC) #18
dak
Han-Wen Nienhuys <hanwenn@gmail.com> writes: > On Thu, Mar 12, 2020 at 10:37 AM <pkx166h@posteo.net> wrote: ...
4 months ago (2020-03-12 11:39:39 UTC) #19
pkx166h_posteo.net
On 12/03/2020 10:32, Han-Wen Nienhuys wrote: > On Thu, Mar 12, 2020 at 10:37 AM ...
4 months ago (2020-03-12 12:15:56 UTC) #20
barrykp
> > > Would docker give us this 'proverbial canary' or would it turn into ...
4 months ago (2020-03-12 12:37:05 UTC) #21
hahnjo
On 2020/03/12 10:10:23, hahnjo wrote: > On 2020/03/12 10:03:22, dak wrote: > > Patch needs ...
4 months ago (2020-03-12 12:38:01 UTC) #22
hahnjo_hahnjo.de
Am Donnerstag, den 12.03.2020, 11:32 +0100 schrieb Han-Wen Nienhuys: > On Thu, Mar 12, 2020 ...
4 months ago (2020-03-12 12:40:47 UTC) #23
pkx166h_posteo.net
On 12/03/2020 12:36, Kevin Barry wrote: > > > Would docker give us this 'proverbial ...
4 months ago (2020-03-12 12:48:56 UTC) #24
barrykp
On Thu, 12 Mar 2020 at 12:48, <pkx166h@posteo.net> wrote: > I'll defer you to Jonas' ...
4 months ago (2020-03-12 13:03:44 UTC) #25
dak
Kevin Barry <barrykp@gmail.com> writes: > On Thu, 12 Mar 2020 at 12:48, <pkx166h@posteo.net> wrote: >> ...
4 months ago (2020-03-12 16:27:07 UTC) #26
barrykp
> > > Frankly, I am more sympathetic to "worksforme" discussions among > developers than ...
4 months ago (2020-03-12 16:50:38 UTC) #27
dak
Kevin Barry <barrykp@gmail.com> writes: >> >> >> Frankly, I am more sympathetic to "worksforme" discussions ...
4 months ago (2020-03-12 17:12:01 UTC) #28
barrykp
> > > I say that having a developer monoculture doesn't buy as anything since ...
4 months ago (2020-03-12 17:35:59 UTC) #29
dan_faithful.be
On Mar 12, 2020, at 08:36, Kevin Barry <barrykp@gmail.com> wrote: > >> Would docker give ...
4 months ago (2020-03-12 23:50:30 UTC) #30
barrykp
> > > The direction of this statement is correct, but the magnitude is not. ...
4 months ago (2020-03-13 08:44:07 UTC) #31
hanwenn
On Thu, Mar 12, 2020 at 6:17 PM David Kastrup <dak@gnu.org> wrote: > > Kevin ...
4 months ago (2020-03-13 11:12:26 UTC) #32
dak
Kevin Barry <barrykp@gmail.com> writes: >> >> >> The direction of this statement is correct, but ...
4 months ago (2020-03-13 12:48:42 UTC) #33
dan_faithful.be
On Mar 13, 2020, at 04:43, Kevin Barry <barrykp@gmail.com> wrote: > > The direction of ...
3 months, 4 weeks ago (2020-03-13 22:33:43 UTC) #34
hanwenn
3 months, 3 weeks ago (2020-03-21 23:05:29 UTC) #35
commit e325a23887fd93e56da2a13dd59a8b82a8ce74a0
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Wed Mar 11 20:58:46 2020 +0100

    Address output-distance problems:
    
    * Run output-distance.py from srcdir
    
    * Generate self-test HTML in out/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b