Issue 563460043: Make all int -> Real casts explicit

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 563460043: Make all int -> Real casts explicit (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 2 months ago by hanwenn

Modified:
4 years, 2 months ago

Reviewers:
Dan Eble

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Make all int -> Real casts explicit

Patch Set 1 #

Patch Set 2 : static_cast #

Total comments: 1

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -15 lines)			Patch
M	lily/lookup.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/mensural-ligature-engraver.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/page-layout-problem.cc	View	1	1 chunk	+3 lines, -2 lines	1 comment	Download
M	lily/page-spacing-result.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/simple-spacer.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/slur.cc	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	lily/slur-configuration.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/stencil-integral.cc	View	1	4 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Dan Eble

4 years, 2 months ago (2020-02-02 18:44:52 UTC) #2

LGTM

https://codereview.appspot.com/563460043/diff/557300058/lily/page-layout-prob...
File lily/page-layout-problem.cc (right):

https://codereview.appspot.com/563460043/diff/557300058/lily/page-layout-prob...
lily/page-layout-problem.cc:739: = overflow / static_cast<Real> (space_count -
2);
This isn't an issue with this change, but does anyone see whether something
prevents division by zero here?  It isn't immediately obvious to me.

Expand All Messages | Collapse All Messages