Issue 5633049: passing flags to firefox driver.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5633049: passing flags to firefox driver.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by francois.reynaud

Modified:
12 years, 2 months ago

Reviewers:
Eran

Base URL:
http://selenium.googlecode.com/svn/trunk

Visibility:
Public.

Description

cleaner patch

Patch Set 1 #

Total comments: 6

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -8 lines)			Patch
		java/client/src/org/openqa/selenium/firefox/FirefoxBinary.java	View		5 chunks	+40 lines, -4 lines	5 comments	Download
		java/client/src/org/openqa/selenium/firefox/FirefoxDriver.java	View		2 chunks	+6 lines, -4 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Eran

12 years, 2 months ago (2012-02-06 15:40:14 UTC) #2

Overall LGTM, there are a few small things to fix - please have a look at the
comments below.

http://codereview.appspot.com/5633049/diff/1/java/client/src/org/openqa/selen...
File java/client/src/org/openqa/selenium/firefox/FirefoxBinary.java (right):

http://codereview.appspot.com/5633049/diff/1/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/firefox/FirefoxBinary.java:54: private long
timeout = SECONDS.toMillis(45);
You could make this list final, since it's initialized in the c'tor.

http://codereview.appspot.com/5633049/diff/1/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/firefox/FirefoxBinary.java:58: public
FirefoxBinary() {
Style: Space between the commas.

http://codereview.appspot.com/5633049/diff/1/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/firefox/FirefoxBinary.java:62: public
FirefoxBinary(File pathToFirefoxBinary) {
Same.

http://codereview.appspot.com/5633049/diff/1/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/firefox/FirefoxBinary.java:89: List<String>
allParams = Lists.newArrayList(commandLineFlags);
According to
http://docs.oracle.com/javase/6/docs/api/java/util/List.html#addAll(java.util...,
You'll get a NPE if extraArguments is null. Either condition this addition or
make sure extraArguments is not null in the c'tor (I prefer the latter).

http://codereview.appspot.com/5633049/diff/1/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/firefox/FirefoxBinary.java:92: CommandLine
command = new CommandLine(
Specifying the size here is a bit confusing: You could either create a new
String array, pass it to toArray and use it, or just call allParams.toArray(new
String[0]);

http://codereview.appspot.com/5633049/diff/1/java/client/src/org/openqa/selen...
File java/client/src/org/openqa/selenium/firefox/FirefoxDriver.java (right):

http://codereview.appspot.com/5633049/diff/1/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/firefox/FirefoxDriver.java:128: private
static FirefoxBinary getBinary(Capabilities capabilities) {
Style: Use spaces rather than tabs for indentation.

Expand All Messages | Collapse All Messages