Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(540)

Issue 5629044: code review 5629044: crypto/...: changes to address some of bug 2841. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by agl1
Modified:
2 years, 2 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

crypto/...: changes to address some of bug 2841.

This change addresses a subset of the issues raised in bug 2841.

Patch Set 1 #

Patch Set 2 : diff -r fbbc8c80bee2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r fbbc8c80bee2 https://go.googlecode.com/hg/ #

Total comments: 6

Patch Set 4 : diff -r fbbc8c80bee2 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r c8794070e276 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -215 lines) Patch
M src/pkg/crypto/cipher/cbc.go View 1 1 chunk +1 line, -1 line 0 comments Download
R src/pkg/crypto/cipher/ocfb.go View 1 1 chunk +0 lines, -138 lines 0 comments Download
R src/pkg/crypto/cipher/ocfb_test.go View 1 1 chunk +0 lines, -44 lines 0 comments Download
M src/pkg/crypto/crypto.go View 1 2 3 3 chunks +16 lines, -11 lines 0 comments Download
M src/pkg/crypto/des/cipher.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/crypto/rsa/pkcs1v15.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/rsa/rsa.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/tls/tls.go View 1 2 chunks +11 lines, -17 lines 0 comments Download
M src/pkg/crypto/x509/pkix/pkix.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
agl1
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
2 years, 2 months ago #1
rsc
LGTM http://codereview.appspot.com/5629044/diff/4001/src/pkg/crypto/crypto.go File src/pkg/crypto/crypto.go (right): http://codereview.appspot.com/5629044/diff/4001/src/pkg/crypto/crypto.go#newcode17 src/pkg/crypto/crypto.go:17: MD4 Hash = 1 + iota // in ...
2 years, 2 months ago #2
agl1
http://codereview.appspot.com/5629044/diff/4001/src/pkg/crypto/crypto.go File src/pkg/crypto/crypto.go (right): http://codereview.appspot.com/5629044/diff/4001/src/pkg/crypto/crypto.go#newcode17 src/pkg/crypto/crypto.go:17: MD4 Hash = 1 + iota // in package ...
2 years, 2 months ago #3
agl1
2 years, 2 months ago #4
*** Submitted as http://code.google.com/p/go/source/detail?r=4d519971228f ***

crypto/...: changes to address some of bug 2841.

This change addresses a subset of the issues raised in bug 2841.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5629044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5