code review 5629044: crypto/...: changes to address some of bug 2841.

crypto/...: changes to address some of bug 2841.

This change addresses a subset of the issues raised in bug 2841.

[agl1, 2012-02-03 19:25:30]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-02-03 19:40:06]

LGTM

http://codereview.appspot.com/5629044/diff/4001/src/pkg/crypto/crypto.go
File src/pkg/crypto/crypto.go (right):

http://codereview.appspot.com/5629044/diff/4001/src/pkg/crypto/crypto.go#newc...
src/pkg/crypto/crypto.go:17: MD4       Hash = 1 + iota // in package
code.google.com/p/go.crypto/md4
s/in package/import/ throughout

http://codereview.appspot.com/5629044/diff/4001/src/pkg/crypto/crypto.go#newc...
src/pkg/crypto/crypto.go:65: // Available returns true if the given hash
function is linked into the binary.
s/returns true if/reports whether/

http://codereview.appspot.com/5629044/diff/4001/src/pkg/crypto/crypto.go#newc...
src/pkg/crypto/crypto.go:67: if h > 0 && h < maxHash {
looks like
return h < len(hashes) && hashes[h] != nil

[agl1, 2012-02-03 19:44:11]

http://codereview.appspot.com/5629044/diff/4001/src/pkg/crypto/crypto.go
File src/pkg/crypto/crypto.go (right):

http://codereview.appspot.com/5629044/diff/4001/src/pkg/crypto/crypto.go#newc...
src/pkg/crypto/crypto.go:17: MD4       Hash = 1 + iota // in package
code.google.com/p/go.crypto/md4
On 2012/02/03 19:40:06, rsc wrote:
> s/in package/import/ throughout

Done.

http://codereview.appspot.com/5629044/diff/4001/src/pkg/crypto/crypto.go#newc...
src/pkg/crypto/crypto.go:65: // Available returns true if the given hash
function is linked into the binary.
On 2012/02/03 19:40:06, rsc wrote:
> s/returns true if/reports whether/

Done.

http://codereview.appspot.com/5629044/diff/4001/src/pkg/crypto/crypto.go#newc...
src/pkg/crypto/crypto.go:67: if h > 0 && h < maxHash {
On 2012/02/03 19:40:06, rsc wrote:
> looks like
> return h < len(hashes) && hashes[h] != nil

Done.

[agl1, 2012-02-03 20:15:16]

*** Submitted as http://code.google.com/p/go/source/detail?r=4d519971228f ***

crypto/...: changes to address some of bug 2841.

This change addresses a subset of the issues raised in bug 2841.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5629044