Issue 5627046: CPP: Fix PhoneNumberMatcher build in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5627046: CPP: Fix PhoneNumberMatcher build in Chrome. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by philippe

Modified:
12 years, 2 months ago

Reviewers:
lararennie, leandrogracia

CC:
shaopengjia, georgey1

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

CPP: Fix PhoneNumberMatcher build in Chrome. Contributors: - leandrogracia@chromium.org - georgey@chromium.org Committed: https://code.google.com/p/libphonenumber/source/detail?r=424

Patch Set 2 : Update #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	cpp/src/phonenumbers/phonenumbermatcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	cpp/test/phonenumbers/phonenumbermatcher_test.cc	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

leandrogracia

Just one minor nit. Thanks for fixing this. http://codereview.appspot.com/5627046/diff/1/cpp/test/phonenumbers/phonenumbermatcher_test.cc File cpp/test/phonenumbers/phonenumbermatcher_test.cc (right): http://codereview.appspot.com/5627046/diff/1/cpp/test/phonenumbers/phonenumbermatcher_test.cc#newcode531 cpp/test/phonenumbers/phonenumbermatcher_test.cc:531: EXPECT_TRUE(IsLatinLetter(UnicodeString("\xCC\x81")[0])); ...

12 years, 2 months ago (2012-02-04 23:56:44 UTC) #2

philippe

http://codereview.appspot.com/5627046/diff/1/cpp/test/phonenumbers/phonenumbermatcher_test.cc File cpp/test/phonenumbers/phonenumbermatcher_test.cc (right): http://codereview.appspot.com/5627046/diff/1/cpp/test/phonenumbers/phonenumbermatcher_test.cc#newcode531 cpp/test/phonenumbers/phonenumbermatcher_test.cc:531: EXPECT_TRUE(IsLatinLetter(UnicodeString("\xCC\x81")[0])); On 2012/02/04 23:56:44, leandrogracia wrote: > fromUTF8 is ...

12 years, 2 months ago (2012-02-06 17:12:32 UTC) #4

leandrogracia

12 years, 2 months ago (2012-02-06 17:14:24 UTC) #5

LGTM. Thanks.

On 2012/02/06 17:12:32, philippe wrote:
>
http://codereview.appspot.com/5627046/diff/1/cpp/test/phonenumbers/phonenumbe...
> File cpp/test/phonenumbers/phonenumbermatcher_test.cc (right):
> 
>
http://codereview.appspot.com/5627046/diff/1/cpp/test/phonenumbers/phonenumbe...
> cpp/test/phonenumbers/phonenumbermatcher_test.cc:531:
> EXPECT_TRUE(IsLatinLetter(UnicodeString("\xCC\x81")[0]));
> On 2012/02/04 23:56:44, leandrogracia wrote:
> > fromUTF8 is required here too.
> 
> Done.

Expand All Messages | Collapse All Messages