Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in

Issue 561810043: Make Scheme_hash_table just use the native hash table type. This

Can't Edit
Can't Publish+Mail
Start Review
3 months ago by dak
3 months ago
Dan Eble


Make Scheme_hash_table just use the native hash table type. This consists of two commits: Implement Scheme_hash_table in terms of Smob0 Introduce Smob0 class without external storage The Smob0 class is actually even more of a joke than the Smob1 class already and makes do without introducing an actual Smob or its own type. It just allows a syntactic class wrapper around an actual Scheme data structure to provide the normal Smob C++ programming interface. There might be a point in trying to make for a way of working with Scheme traits that does not go through class pointers as a prescribed interface in the first place. In the current framework, this may be the cheapest way to get rid of an additional class indirection without losing the convenience of working with a fixed C++ type and associated member functions.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M lily/include/scm-hash.hh View 2 chunks +7 lines, -2 lines 0 comments Download
M lily/include/small-smobs.hh View 1 chunk +18 lines, -0 lines 0 comments Download
M lily/scm-hash.cc View 1 chunk +1 line, -10 lines 0 comments Download


Total messages: 1
Dan Eble
3 months ago (2020-05-09 14:05:41 UTC) #1
LGTM.  Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b