Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8553)

Issue 56170043: uncomments open-port in start hook

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by lazypower
Modified:
8 years, 9 months ago
Reviewers:
Marco Ceppi, mp+202952
Visibility:
Public.

Description

uncomments open-port in start hook https://code.launchpad.net/~lazypower/charms/precise/elasticsearch/fix_ports/+merge/202952 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 7

Patch Set 2 : uncomments open-port in start hook #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -3 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M config.yaml View 2 chunks +3 lines, -0 lines 0 comments Download
M hooks/start View 2 chunks +3 lines, -3 lines 0 comments Download
A icon.svg View 1 chunk +287 lines, -0 lines 0 comments Download
M metadata.yaml View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/00_setup.sh View 1 1 chunk +9 lines, -0 lines 0 comments Download
A tests/100_deploy.test View 1 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 4
lazypower
Please take a look.
8 years, 10 months ago (2014-01-23 21:16:19 UTC) #1
Marco Ceppi
See inline, good start needs work. Thanks! https://codereview.appspot.com/56170043/diff/1/tests/00_setup.sh File tests/00_setup.sh (right): https://codereview.appspot.com/56170043/diff/1/tests/00_setup.sh#newcode3 tests/00_setup.sh:3: sudo apt-get ...
8 years, 10 months ago (2014-01-31 11:44:53 UTC) #2
lazypower
Please take a look.
8 years, 10 months ago (2014-01-31 16:40:17 UTC) #3
Marco Ceppi
8 years, 9 months ago (2014-02-08 15:16:06 UTC) #4
LGTM. Ultimately I think we'd want to see more exercising of configuration
options but this is mvp
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b