uncomments open-port in start hook

uncomments open-port in start hook



https://code.launchpad.net/~lazypower/charms/precise/elasticsearch/fix_ports/+merge/202952

(do not edit description out of merge proposal)

[lazypower, 2014-01-23 21:16:19]

Please take a look.

[Marco Ceppi, 2014-01-31 11:44:53]

See inline, good start needs work. Thanks!

https://codereview.appspot.com/56170043/diff/1/tests/00_setup.sh
File tests/00_setup.sh (right):

https://codereview.appspot.com/56170043/diff/1/tests/00_setup.sh#newcode3
tests/00_setup.sh:3: sudo apt-get install install amulet python-requests
there is no install package, missing other deps

https://codereview.appspot.com/56170043/diff/1/tests/100_deploy.test
File tests/100_deploy.test (right):

https://codereview.appspot.com/56170043/diff/1/tests/100_deploy.test#newcode39
tests/100_deploy.test:39: print(json.dumps(d.schema(), indent=2))
This is pretty much debugging, probably don't need it anymore.

https://codereview.appspot.com/56170043/diff/1/tests/100_deploy.test#newcode75
tests/100_deploy.test:75: def healthcheck():
to avoid ambiguity with global variables, it might be better to have 

def healthcheck(address):

then pass d.sentry.unit['elasticsearch/0'].info['public-address'] to healthcheck
and simply use the address variable since you don't use any other unit
information

https://codereview.appspot.com/56170043/diff/1/tests/100_deploy.test#newcode81
tests/100_deploy.test:81: health.raise_for_status
This is a function, not a key. health.raise_for_status()

https://codereview.appspot.com/56170043/diff/1/tests/100_deploy.test#newcode82
tests/100_deploy.test:82: json_output = json.loads(health.content.decode())
json_output = health.json() would be better here

https://codereview.appspot.com/56170043/diff/1/tests/100_deploy.test#newcode88
tests/100_deploy.test:88: amulet.raise_status(amulet.SKIP, msg="Configured
cluster-name failed check")
This seems like a FAIL condition, not a SKIP

https://codereview.appspot.com/56170043/diff/1/tests/100_deploy.test#newcode92
tests/100_deploy.test:92: amulet.raise_status(amulet.SKIP, msg="Scale check
failed, expected: {}, got: {}".format(scale, json_output['number_of_nodes']))
Again, seems like a FAIL if it didn't configure properly

[lazypower, 2014-01-31 16:40:17]

Please take a look.

[Marco Ceppi, 2014-02-08 15:16:06]

LGTM. Ultimately I think we'd want to see more exercising of configuration
options but this is mvp