Issue 5616058: store: refactored AddCharm into a CharmPublisher

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5616058: store: refactored AddCharm into a CharmPublisher

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by niemeyer

Modified:
12 years, 3 months ago

Reviewers:
mp+91336

Visibility:
Public.

Description

AddCharm required having the charm at hand when it was first called, which meant the application would have to download the charm and be ready to bundle it before even knowing if the charm was already up-to-date or not. This refactoring improves the situation by moving the charm importing aspect onto a CharmPublisher, so when one is acquiring the charm publisher from the store, it's already possible to tell if a charm with the given URL and digest should not be imported, and not even downloaded. This change also simplfies other aspects. Now the whole importing procedure sits within CharmPublisher.Publish, including publishing of successful and failure events. There is still a reason to publish failure events outside of the Publish method, but a lot is being covered internally. https://code.launchpad.net/~niemeyer/juju/store-charm-publisher/+merge/91336 (do not edit description out of merge proposal)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+295 lines, -173 lines)			Patch
M	charm/url.go	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	store/store.go	View	1 2	10 chunks	+123 lines, -72 lines	0 comments	Download
M	store/store_test.go	View	1 2	12 chunks	+170 lines, -99 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

12 years, 3 months ago (2012-02-08 01:35:32 UTC) #5

*** Submitted:

store: refactored AddCharm into a CharmPublisher

AddCharm required having the charm at hand when it was first called,
which meant the application would have to download the charm and
be ready to bundle it before even knowing if the charm was already
up-to-date or not.

This refactoring improves the situation by moving the charm importing
aspect onto a CharmPublisher, so when one is acquiring the charm
publisher from the store, it's already possible to tell if a charm
with the given URL and digest should not be imported, and not even
downloaded.

This change also simplfies other aspects. Now the whole importing
procedure sits within CharmPublisher.Publish, including publishing
of successful and failure events. There is still a reason to
publish failure events outside of the Publish method, but a lot
is being covered internally.

R=fwereade
CC=
https://codereview.appspot.com/5616058

Expand All Messages | Collapse All Messages