Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(763)

Issue 561340043: Add a tentative .clang-format for LilyPond. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 1 week ago by hanwenn
Modified:
4 months, 4 weeks ago
Reviewers:
carl.d.sorensen, Dan Eble, Carl, dak, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add a tentative .clang-format for LilyPond. To try it out, run clang-format -i lily/include/*[ch] lily/*.cc

Patch Set 1 #

Patch Set 2 : just the overrides #

Patch Set 3 : reflow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
A .clang-format View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 17
lemzwerg
For which clang-format version is this format file? It doesn't work with 7.0.1, for example. ...
5 months, 1 week ago (2020-01-27 10:07:20 UTC) #1
hanwenn
On 2020/01/27 10:07:20, lemzwerg wrote: > For which clang-format version is this format file? It ...
5 months, 1 week ago (2020-01-29 06:45:53 UTC) #2
hanwenn
just the overrides
5 months, 1 week ago (2020-01-29 06:55:54 UTC) #3
lemzwerg
> just the overrides The new version works just fine. Shall I still inspect the ...
5 months, 1 week ago (2020-01-29 07:41:40 UTC) #4
Dan Eble
On 2020/01/29 07:41:40, lemzwerg wrote: > The output looks good. BTW, for the sake of ...
5 months, 1 week ago (2020-01-29 12:19:54 UTC) #5
hanwenn
reflow
5 months, 1 week ago (2020-01-30 09:24:17 UTC) #6
hanwenn
On 2020/01/29 12:19:54, Dan Eble wrote: > On 2020/01/29 07:41:40, lemzwerg wrote: > > The ...
5 months, 1 week ago (2020-01-31 09:39:33 UTC) #7
Dan Eble
On 2020/01/31 09:39:33, hanwenn wrote: > I've applied your suggestion; PTAL. If Werner likes it, ...
5 months, 1 week ago (2020-01-31 12:35:45 UTC) #8
hanwenn
On 2020/01/31 12:35:45, Dan Eble wrote: > On 2020/01/31 09:39:33, hanwenn wrote: > > I've ...
5 months, 1 week ago (2020-01-31 18:06:00 UTC) #9
Carl
IIUC, this is a .clang-format that can be (but is not required to be) used ...
5 months, 1 week ago (2020-01-31 18:33:38 UTC) #10
hanwenn
On 2020/01/31 18:33:38, Carl wrote: > IIUC, this is a .clang-format that can be (but ...
5 months, 1 week ago (2020-01-31 18:35:18 UTC) #11
Carl
On 2020/01/31 18:06:00, hanwenn wrote: > Will james pick this up automatically now, or does ...
5 months, 1 week ago (2020-01-31 18:37:33 UTC) #12
lemzwerg
> If Werner likes it, I'm fine with it. I do like it, and it ...
5 months, 1 week ago (2020-02-01 07:07:32 UTC) #13
Dan Eble
I'm running some of my patches through clang-format as I prepare to push them. This ...
5 months ago (2020-02-04 20:35:40 UTC) #14
hanwenn
On 2020/02/04 20:35:40, Dan Eble wrote: > I'm running some of my patches through clang-format ...
5 months ago (2020-02-04 22:18:23 UTC) #15
dak
On 2020/02/04 22:18:23, hanwenn wrote: > On 2020/02/04 20:35:40, Dan Eble wrote: > > I'm ...
5 months ago (2020-02-04 23:40:03 UTC) #16
Dan Eble
5 months ago (2020-02-05 00:00:17 UTC) #17
On 2020/02/04 23:40:03, dak wrote:
> Personally, the best of two worlds would be if a ping-pong between our current
> Astyle and clang-format would end up stable after one application of each. 
That
> way, putting the code base through both Astyle and clang-format semi-regularly
> would put it into a form where users of either formatting tool could
contribute
> their changes without affecting already formatted code in the same file.

+1.  I actually tried that earlier today, and there were lots of differences.  I
was using astyle 3.1 because that's what I had, so I'm not sure it represents
the ideal, but I'm confident that this clang-format file needs some work
regardless.  It's a good start, though.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b