Issue 56100043: state/apiserver: different logging interface

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 56100043: state/apiserver: different logging interface

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by rog

Modified:
10 years, 3 months ago

Reviewers:
mp+202909, thumper

Visibility:
Public.

Description

state/apiserver: different logging interface This code compiles but I haven't run it. It needs tests and client-side code, but hopefully this points the way, https://code.launchpad.net/~rogpeppe/juju-core/themue-058-debug-log-api/+merge/202909 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/apiserver: different logging interface #

Total comments: 1

Patch Set 3 : state/apiserver: different logging interface #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+250 lines, -297 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/plugins/juju-restore/restore.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	state/api/apiclient.go	View	1 2	3 chunks	+13 lines, -8 lines	0 comments	Download
M	state/api/client.go	View	1 2	3 chunks	+72 lines, -1 line	0 comments	Download
M	state/api/export_test.go	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	state/api/params/params.go	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	state/apiserver/apiserver.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	state/apiserver/charms.go	View		3 chunks	+8 lines, -4 lines	0 comments	Download
A	state/apiserver/log.go	View		1 chunk	+103 lines, -0 lines	0 comments	Download
D	state/apiserver/logger/logger.go	View		1 chunk	+0 lines, -93 lines	0 comments	Download
D	state/apiserver/logger/logger_test.go	View		1 chunk	+0 lines, -147 lines	0 comments	Download
D	state/apiserver/logger/package_test.go	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	state/apiserver/root.go	View		3 chunks	+0 lines, -14 lines	0 comments	Download
M	testing/checkers/deepequal_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/tailer/tailer.go	View		6 chunks	+20 lines, -9 lines	0 comments	Download
M	utils/tailer/tailer_test.go	View		4 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thumper

10 years, 3 months ago (2014-01-23 20:34:41 UTC) #3

https://codereview.appspot.com/56100043/diff/20001/state/apiserver/log.go
File state/apiserver/log.go (right):

https://codereview.appspot.com/56100043/diff/20001/state/apiserver/log.go#new...
state/apiserver/log.go:22: logLocation = "/var/log/juju/all-machines.log"
This isn't correct for the local provider.

Expand All Messages | Collapse All Messages