Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(723)

Issue 5607048: gnuflag: define ordering of shortest flags

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by rog
Modified:
11 years, 6 months ago
Reviewers:
mp+91053
Visibility:
Public.

Description

gnuflag: define ordering of shortest flags If there are several shortest possible flag names for the same value, define that the least alphabetically will be used. Also fix test package identifiers and bring output handling into line with latest Go version. https://code.launchpad.net/~rogpeppe/gnuflag/define-flag-ordering/+merge/91053 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 10

Patch Set 2 : gnuflag: define ordering of shortest flags #

Patch Set 3 : gnuflag: define ordering of shortest flags #

Patch Set 4 : gnuflag: define ordering of shortest flags #

Patch Set 5 : gnuflag: define ordering of shortest flags #

Patch Set 6 : gnuflag: define ordering of shortest flags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -158 lines) Patch
A [revision details] View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M flag.go View 1 2 3 4 5 4 chunks +18 lines, -3 lines 0 comments Download
M flag_test.go View 1 2 3 4 5 2 chunks +179 lines, -155 lines 0 comments Download

Messages

Total messages: 10
rog
Please take a look.
12 years, 1 month ago (2012-02-01 11:14:34 UTC) #1
fwereade
LGTM
12 years, 1 month ago (2012-02-02 10:18:53 UTC) #2
TheMue
https://codereview.appspot.com/5607048/diff/1/flag.go File flag.go (right): https://codereview.appspot.com/5607048/diff/1/flag.go#newcode3 flag.go:3: // license that can be found in the LICENSE ...
12 years, 1 month ago (2012-02-02 10:39:00 UTC) #3
rog
Please take a look.
12 years, 1 month ago (2012-02-02 11:14:03 UTC) #4
rog
Please take a look.
12 years, 1 month ago (2012-02-02 11:15:08 UTC) #5
rog
Please take a look.
12 years, 1 month ago (2012-02-02 11:26:17 UTC) #6
rog
PTAL https://codereview.appspot.com/5607048/diff/1/flag.go File flag.go (right): https://codereview.appspot.com/5607048/diff/1/flag.go#newcode3 flag.go:3: // license that can be found in the ...
12 years, 1 month ago (2012-02-02 11:26:46 UTC) #7
TheMue
LGTM On 2012/02/02 11:26:46, rog wrote: > PTAL > > https://codereview.appspot.com/5607048/diff/1/flag.go > File flag.go (right): ...
12 years, 1 month ago (2012-02-02 11:30:18 UTC) #8
rog
On 2012/02/02 11:30:18, TheMue wrote: > LGTM > > On 2012/02/02 11:26:46, rog wrote: > ...
12 years, 1 month ago (2012-02-27 08:40:02 UTC) #9
rog
12 years, 1 month ago (2012-02-27 08:40:42 UTC) #10
*** Submitted:

gnuflag: define ordering of shortest flags

If there are several shortest possible flag names for
the same value, define that the least alphabetically
will be used.

Also fix test package identifiers and bring output handling
into line with latest Go version.

R=fwereade, TheMue
CC=
https://codereview.appspot.com/5607048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b