Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(67)

Issue 560670043: Document bound-details (sub-)properties in line-spanner-cc for IR (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by thomasmorley651
Modified:
1 month, 3 weeks ago
Reviewers:
dak, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Document bound-details (sub-)properties in line-spanner-cc for IR

Patch Set 1 #

Total comments: 13

Patch Set 2 : Adress Werner and David #

Total comments: 2

Patch Set 3 : Werners recent comments (hopefully) #

Patch Set 4 : Corrrect misleading doc of stencil-align-dir-y/stencil-offset #

Total comments: 6

Patch Set 5 : Werner's recent comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M lily/line-spanner.cc View 1 2 3 4 1 chunk +46 lines, -1 line 0 comments Download

Messages

Total messages: 15
thomasmorley651
Please review
2 months, 1 week ago (2019-05-09 21:01:59 UTC) #1
lemzwerg
LGTM, thanks. Only cosmetic nits :-) https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc File lily/line-spanner.cc (right): https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode395 lily/line-spanner.cc:395: "Sets the Y-coordinate ...
2 months ago (2019-05-10 05:22:32 UTC) #2
dak
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc File lily/line-spanner.cc (right): https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode395 lily/line-spanner.cc:395: "Sets the Y-coordinate of the end point, in staff-spaces" ...
2 months ago (2019-05-10 10:33:13 UTC) #3
lemzwerg
> I think I'd at least stick with uppercase since it evokes the #X > ...
2 months ago (2019-05-10 20:23:49 UTC) #4
thomasmorley651
Adress Werner and David
2 months ago (2019-05-10 20:28:04 UTC) #5
thomasmorley651
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc File lily/line-spanner.cc (right): https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode395 lily/line-spanner.cc:395: "Sets the Y-coordinate of the end point, in staff-spaces" ...
2 months ago (2019-05-10 20:34:53 UTC) #6
lemzwerg
https://codereview.appspot.com/560670043/diff/552680043/lily/line-spanner.cc File lily/line-spanner.cc (right): https://codereview.appspot.com/560670043/diff/552680043/lily/line-spanner.cc#newcode421 lily/line-spanner.cc:421: " of the line" Oh, here (and at similar ...
2 months ago (2019-05-11 03:55:46 UTC) #7
thomasmorley651
Werners recent comments (hopefully)
2 months ago (2019-05-12 12:49:03 UTC) #8
thomasmorley651
On 2019/05/11 03:55:46, lemzwerg wrote: > https://codereview.appspot.com/560670043/diff/552680043/lily/line-spanner.cc > File lily/line-spanner.cc (right): > > https://codereview.appspot.com/560670043/diff/552680043/lily/line-spanner.cc#newcode421 > ...
2 months ago (2019-05-12 12:49:52 UTC) #9
lemzwerg
LGTM, thanks.
2 months ago (2019-05-12 12:57:16 UTC) #10
thomasmorley651
Corrrect misleading doc of stencil-align-dir-y/stencil-offset
2 months ago (2019-05-13 21:03:51 UTC) #11
lemzwerg
https://codereview.appspot.com/560670043/diff/582680043/lily/line-spanner.cc File lily/line-spanner.cc (right): https://codereview.appspot.com/560670043/diff/582680043/lily/line-spanner.cc#newcode421 lily/line-spanner.cc:421: " @code{stencil-offset}, expecting a number-pair, the stencil" s/number-pair/number pair/ ...
2 months ago (2019-05-14 03:52:11 UTC) #12
thomasmorley651
Werner's recent comments
2 months ago (2019-05-15 18:59:17 UTC) #13
thomasmorley651
https://codereview.appspot.com/560670043/diff/582680043/lily/line-spanner.cc File lily/line-spanner.cc (right): https://codereview.appspot.com/560670043/diff/582680043/lily/line-spanner.cc#newcode421 lily/line-spanner.cc:421: " @code{stencil-offset}, expecting a number-pair, the stencil" On 2019/05/14 ...
2 months ago (2019-05-15 19:01:07 UTC) #14
thomasmorley651
1 month, 3 weeks ago (2019-05-22 22:28:32 UTC) #15
Thanks for review
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b