Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3454)

Issue 5606053: store: simplify storage of CharmEvent

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by niemeyer
Modified:
12 years, 3 months ago
Reviewers:
mp+91249
Visibility:
Public.

Description

This will also introduce bson marshaling of charm.URL and port the store code to mgo tip (time.Time must be used instead of bson.Timestamp). https://code.launchpad.net/~niemeyer/juju/store-simpler-events/+merge/91249 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : store: simplify storage of CharmEvent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -70 lines) Patch
M charm/url.go View 2 chunks +23 lines, -0 lines 0 comments Download
M store/store.go View 5 chunks +22 lines, -67 lines 0 comments Download
M store/store_test.go View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
niemeyer
Please take a look.
12 years, 3 months ago (2012-02-02 11:58:09 UTC) #1
fwereade
LGTM
12 years, 3 months ago (2012-02-02 12:39:06 UTC) #2
niemeyer
12 years, 3 months ago (2012-02-02 19:20:28 UTC) #3
*** Submitted:

store: simplify storage of CharmEvent

This will also introduce bson marshaling of charm.URL and
port the store code to mgo tip (time.Time must be used
instead of bson.Timestamp).

R=fwereade
CC=
https://codereview.appspot.com/5606053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b