Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(78)

Issue 560030044: Remove deprecated context properties

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 6 days ago by Valentin Villenave
Modified:
3 weeks, 6 days ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Remove deprecated context properties - bassFigureFormatFunction was dropped in 2.7.18 in favor of figuredBassFormatter. Removed throughout the doc, with a convert rule. - alignBassFigureAccidentals was deprecated even earlier, in 2.7.13. Added to the aforementioned convert-rule. - chordNameExceptionsFull and chordNameExceptionsPartial have been deprecated at least since I rewrote the chord naming functions in 2.21.0; the only trace left is in the chord-names-alternative snippet.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -20 lines) Patch
M Documentation/ca/notation/rhythms.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/de/notation/rhythms.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/es/notation/rhythms.itely View 1 chunk +0 lines, -1 line 0 comments Download
M Documentation/fr/notation/rhythms.itely View 1 chunk +0 lines, -1 line 0 comments Download
M Documentation/it/notation/rhythms.itely View 1 chunk +0 lines, -1 line 0 comments Download
M Documentation/ja/notation/rhythms.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/notation/rhythms.itely View 1 chunk +0 lines, -1 line 0 comments Download
M Documentation/snippets/chord-names-alternative.ly View 1 chunk +21 lines, -0 lines 0 comments Download
M python/convertrules.py View 1 chunk +10 lines, -0 lines 0 comments Download
M scm/define-context-properties.scm View 5 chunks +2 lines, -13 lines 1 comment Download

Messages

Total messages: 4
lemzwerg
LGTM. This issue also adds some scheme code and a conversion rule – they are ...
3 weeks, 6 days ago (2020-05-09 18:25:03 UTC) #1
thomasmorley651
Not sure about chordNameExceptionsFull and chordNameExceptionsPartial. I thought our deprecating policy would be to wait ...
3 weeks, 6 days ago (2020-05-09 20:17:09 UTC) #2
Valentin Villenave
On 2020/05/09 20:17:09, thomasmorley651 wrote: > Not sure about chordNameExceptionsFull and chordNameExceptionsPartial. > I thought ...
3 weeks, 6 days ago (2020-05-10 08:04:02 UTC) #3
Valentin Villenave
3 weeks, 6 days ago (2020-05-10 08:08:14 UTC) #4
On 2020/05/09 18:25:03, lemzwerg wrote:
>
https://codereview.appspot.com/560030044/diff/557800043/scm/define-context-pr...
> scm/define-context-properties.scm:609: merge rests when this is set to true.")
> While you are at it, please fix indentation (i.e., no indentation for the
> continuation line).

Acknowledged.

> LGTM.  This issue also adds some scheme code and a conversion rule – they are
> different commits, right?

Should they really be? The scheme code (largely inspired by Harm BTW :-) is only
needed for the snippet (which will get updated through next makelsr anyway).

As for define-context-properties.scm, it’s used in the doc so I thought it’d
make sense to have that in the same commit that the @funindex cleanup.

V.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b