Remove deprecated context properties

Remove deprecated context properties

- bassFigureFormatFunction was dropped in 2.7.18 in favor of
figuredBassFormatter.  Removed throughout the doc, with a
convert rule.

- alignBassFigureAccidentals was deprecated even earlier, in 2.7.13.
Added to the aforementioned convert-rule.

- chordNameExceptionsFull and chordNameExceptionsPartial have been
deprecated at least since I rewrote the chord naming functions in
2.21.0; the only trace left is in the chord-names-alternative snippet.

[lemzwerg, 2020-05-09 18:25:03]

LGTM.  This issue also adds some scheme code and a conversion rule – they are
different commits, right?

https://codereview.appspot.com/560030044/diff/557800043/scm/define-context-pr...
File scm/define-context-properties.scm (right):

https://codereview.appspot.com/560030044/diff/557800043/scm/define-context-pr...
scm/define-context-properties.scm:609: merge rests when this is set to true.")
While you are at it, please fix indentation (i.e., no indentation for the
continuation line).

[thomasmorley651, 2020-05-09 20:17:09]

Not sure about chordNameExceptionsFull and chordNameExceptionsPartial.
I thought our deprecating policy would be to wait for 1 or even 2 stable
versions before deleting from source.
Well, the snippet demonstrates a user-level reimplementation, but this makes
little sense to me. Also, banter-style is gone as well, afaik.

[Valentin Villenave, 2020-05-10 08:04:02]

On 2020/05/09 20:17:09, thomasmorley651 wrote:
> Not sure about chordNameExceptionsFull and chordNameExceptionsPartial.
> I thought our deprecating policy would be to wait for 1 or even 2 stable
> versions before deleting from source.

Actually, all that was deprecated _long_ ago, much longer than 1 or 2 stable
releases:
https://lists.gnu.org/archive/html/lilypond-user/2008-08/msg00389.html

I just made that clearer (and even added a convert-rule for banter-style) :
https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=78225bc1b386e12dc1d...

V.

[Valentin Villenave, 2020-05-10 08:08:14]

On 2020/05/09 18:25:03, lemzwerg wrote:
>
https://codereview.appspot.com/560030044/diff/557800043/scm/define-context-pr...
> scm/define-context-properties.scm:609: merge rests when this is set to true.")
> While you are at it, please fix indentation (i.e., no indentation for the
> continuation line).

Acknowledged.

> LGTM.  This issue also adds some scheme code and a conversion rule – they are
> different commits, right?

Should they really be? The scheme code (largely inspired by Harm BTW :-) is only
needed for the snippet (which will get updated through next makelsr anyway).

As for define-context-properties.scm, it’s used in the doc so I thought it’d
make sense to have that in the same commit that the @funindex cleanup.

V.