Issue 5600051: CPP: libphonenumber 4.5

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5600051: CPP: libphonenumber 4.5 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by philippe

Modified:
12 years, 3 months ago

Reviewers:
lararennie, Shaopeng

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

CPP: libphonenumber 4.5

Created: 12 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1364 lines, -745 lines)			Patch
M	cpp/src/phonenumbers/asyoutypeformatter.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	cpp/src/phonenumbers/phonenumberutil.h	View	8 chunks	+53 lines, -17 lines	0 comments	Download
M	cpp/src/phonenumbers/phonenumberutil.cc	View	37 chunks	+272 lines, -103 lines	0 comments	Download
M	cpp/src/phonenumbers/test_metadata.cc	View	3 chunks	+661 lines, -614 lines	0 comments	Download
M	cpp/test/phonenumbers/phonenumberutil_test.cc	View	36 chunks	+366 lines, -9 lines	0 comments	Download
M	cpp/test/phonenumbers/test_util.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 6

lararennie

I assume you have a metadata file too that changed? That was too large to ...

12 years, 3 months ago (2012-01-31 07:58:28 UTC) #3

philippe

You are welcome :) Indeed, the metadata.cc file is not displayed only because it is ...

12 years, 3 months ago (2012-01-31 17:11:47 UTC) #4

philippe

12 years, 3 months ago (2012-02-01 21:37:41 UTC) #6

On 2012/02/01 08:13:07, Shaopeng wrote:
> LGTM. Thanks for the work, Philippe!

Committed as r423 :)