Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(996)

Issue 559930043: Doc: mention tuplet-slur in Changes and in NR 1.2.1.2 "Tuplets"

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by Valentin Villenave
Modified:
2 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: mention tuplet-slur in Changes and in NR 1.2.1.2 "Tuplets" See issue #5567 for David Nalesnik’s original patch. Documenting why the bracket-visibility default behavior isn’t suited to tuplet-slurs allows me to explicitely point towards the relevant snippet for more clarity, and to add a couple of additional internal references.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -7 lines) Patch
M Documentation/changes.tely View 2 chunks +15 lines, -0 lines 0 comments Download
M Documentation/notation/rhythms.itely View 3 chunks +34 lines, -4 lines 2 comments Download
M Documentation/snippets/controlling-tuplet-bracket-visibility.ly View 2 chunks +4 lines, -3 lines 1 comment Download

Messages

Total messages: 2
lemzwerg
LGTM, thanks! https://codereview.appspot.com/559930043/diff/549940043/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/559930043/diff/549940043/Documentation/notation/rhythms.itely#newcode275 Documentation/notation/rhythms.itely:275: @cindex tuplet slur Add: @cindex slur, for ...
2 months, 1 week ago (2020-04-30 19:33:03 UTC) #1
Valentin Villenave
2 months ago (2020-05-07 12:05:52 UTC) #2
On 2020/04/30 19:33:03, lemzwerg wrote:
> LGTM, thanks!

Thanks Werner!  I added your suggestions and pushed it as
https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=ee56da0f7a68cb6d6c5...

V.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b