Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 5593050: Node Group Interface

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by lukas.toenne
Modified:
7 years, 6 months ago
Reviewers:
bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

This patch implements one of the main features described in my recent code.blender.org blogpost [1] It replaces the current lists of sockets on either side of the group editing window by internal "proxy nodes". This is avoids long node connections from the sides of a node group and provides a place to edit all the details of a node group interface socket. It also simplifies code by removing the need to take additional socket lists into account. In the future the proxy nodes could be used for creating external interfaces for regular (non-group) node trees as well. User wiki documentation can be found here [2]. (I noticed there is currently no wiki docs section on general node editing features, beside specifics for shader/compositor nodes. Would be a good idea to make one and integrate this info there.) NOTE: This version of the patch does not include changes to startup.blend for size reasons, which means the proxy node theme color will be black by default. [1] http://code.blender.org/index.php/2012/01/improving-node-group-interface-editing/ [2] http://wiki.blender.org/index.php/User:Phonybone/NodeTreeInterface

Patch Set 1 #

Patch Set 2 : Removed proxy node ntree storage, this causes problems with do_versions + lib_link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2317 lines, -1552 lines) Patch
intern/cycles/blender/blender_shader.cpp View 1 8 chunks +114 lines, -82 lines 0 comments Download
intern/cycles/render/nodes.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
intern/cycles/render/nodes.cpp View 1 1 chunk +4 lines, -5 lines 0 comments Download
source/blender/blenkernel/BKE_blender.h View 1 1 chunk +1 line, -1 line 0 comments Download
source/blender/blenkernel/BKE_node.h View 1 5 chunks +20 lines, -21 lines 0 comments Download
source/blender/blenkernel/intern/node.c View 1 20 chunks +215 lines, -96 lines 0 comments Download
source/blender/blenloader/intern/readfile.c View 1 16 chunks +317 lines, -29 lines 0 comments Download
source/blender/blenloader/intern/writefile.c View 1 2 chunks +5 lines, -5 lines 0 comments Download
source/blender/editors/include/UI_resources.h View 1 1 chunk +1 line, -0 lines 0 comments Download
source/blender/editors/interface/resources.c View 1 3 chunks +4 lines, -1 line 0 comments Download
source/blender/editors/space_node/drawnode.c View 1 14 chunks +224 lines, -279 lines 0 comments Download
source/blender/editors/space_node/node_draw.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
source/blender/editors/space_node/node_edit.c View 1 12 chunks +467 lines, -274 lines 0 comments Download
source/blender/editors/space_node/node_intern.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
source/blender/editors/space_node/node_ops.c View 1 5 chunks +10 lines, -5 lines 0 comments Download
source/blender/editors/space_node/node_select.c View 1 2 chunks +94 lines, -0 lines 0 comments Download
source/blender/editors/space_node/node_templates.c View 1 2 chunks +46 lines, -103 lines 0 comments Download
source/blender/makesdna/DNA_node_types.h View 1 5 chunks +17 lines, -3 lines 0 comments Download
source/blender/makesrna/RNA_access.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
source/blender/makesrna/intern/CMakeLists.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
source/blender/makesrna/intern/rna_nodetree.c View 1 18 chunks +417 lines, -128 lines 0 comments Download
source/blender/makesrna/intern/rna_userdef.c View 1 1 chunk +6 lines, -0 lines 0 comments Download
source/blender/nodes/CMakeLists.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
source/blender/nodes/NOD_common.h View 1 chunk +48 lines, -0 lines 0 comments Download
source/blender/nodes/NOD_socket.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
source/blender/nodes/composite/nodes/node_composite_common.c View 1 4 chunks +23 lines, -15 lines 0 comments Download
source/blender/nodes/composite/nodes/node_composite_moviedistortion.c View 1 1 chunk +3 lines, -3 lines 0 comments Download
source/blender/nodes/intern/node_common.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
source/blender/nodes/intern/node_common.c View 1 11 chunks +137 lines, -413 lines 0 comments Download
source/blender/nodes/intern/node_exec.c View 1 5 chunks +2 lines, -17 lines 0 comments Download
source/blender/nodes/intern/node_socket.c View 1 6 chunks +66 lines, -22 lines 0 comments Download
source/blender/nodes/intern/node_util.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
source/blender/nodes/intern/node_util.c View 1 1 chunk +4 lines, -4 lines 0 comments Download
source/blender/nodes/shader/nodes/node_shader_common.c View 1 4 chunks +34 lines, -22 lines 0 comments Download
source/blender/nodes/texture/nodes/node_texture_common.c View 1 2 chunks +16 lines, -10 lines 0 comments Download
source/blender/nodes/texture/nodes/node_texture_output.c View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2
lukas.toenne
10 years, 5 months ago (2012-01-29 11:47:37 UTC) #1
lukas.toenne
10 years, 4 months ago (2012-02-09 16:26:24 UTC) #2
Removed proxy node ntree storage, this causes problems with do_versions +
lib_link
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b