Issue 55840043: Add environment config watcher to the uniter.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 55840043: Add environment config watcher to the uniter.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by thumper

Modified:
10 years, 3 months ago

Reviewers:
mp+202780, axw

Visibility:
Public.

Description

Add environment config watcher to the uniter. As a part of this, introduce the common testing. Since the client and server components are now using common code to provide the methods, we should also be using common code for the tests instead of just duplicating them. https://code.launchpad.net/~thumper/juju-core/unit-agent-proxy-settings/+merge/202780 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 6

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+244 lines, -118 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	state/api/common/testing/environwatcher.go	View	1 chunk	+95 lines, -0 lines	4 comments	Download
M	state/api/provisioner/provisioner_test.go	View	4 chunks	+5 lines, -40 lines	0 comments	Download
M	state/api/uniter/uniter.go	View	6 chunks	+13 lines, -6 lines	0 comments	Download
M	state/api/uniter/uniter_test.go	View	2 chunks	+15 lines, -0 lines	0 comments	Download
A	state/apiserver/common/testing/environwatcher.go	View	1 chunk	+91 lines, -0 lines	2 comments	Download
M	state/apiserver/firewaller/firewaller_test.go	View	4 chunks	+3 lines, -30 lines	0 comments	Download
M	state/apiserver/provisioner/provisioner_test.go	View	5 chunks	+5 lines, -37 lines	0 comments	Download
M	state/apiserver/uniter/uniter.go	View	2 chunks	+12 lines, -5 lines	0 comments	Download
M	state/apiserver/uniter/uniter_test.go	View	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

axw

LGTM, though I think "Implementer" could be renamed. The secrets-assigned-to strings comment is future-looking, AFAIK ...

10 years, 3 months ago (2014-01-23 02:46:34 UTC) #2

thumper

10 years, 3 months ago (2014-01-23 04:46:29 UTC) #3

https://codereview.appspot.com/55840043/diff/1/state/api/common/testing/envir...
File state/api/common/testing/environwatcher.go (right):

https://codereview.appspot.com/55840043/diff/1/state/api/common/testing/envir...
state/api/common/testing/environwatcher.go:22: type Facade interface {
On 2014/01/23 02:46:35, axw wrote:
> s/Facade/Façade/

Done.

https://codereview.appspot.com/55840043/diff/1/state/api/common/testing/envir...
state/api/common/testing/environwatcher.go:58: secrets[key] = "not available"
On 2014/01/23 02:46:35, axw wrote:
> Is it safe to just assign a string? Can secrets not be other types?

This is matching the apiserver common implementation.

https://codereview.appspot.com/55840043/diff/1/state/apiserver/common/testing...
File state/apiserver/common/testing/environwatcher.go (right):

https://codereview.appspot.com/55840043/diff/1/state/apiserver/common/testing...
state/apiserver/common/testing/environwatcher.go:22: type Implementer interface
{
On 2014/01/23 02:46:35, axw wrote:
> s/Implementer/EnvironWatcher/?

Done.

Expand All Messages | Collapse All Messages