Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(624)

Issue 557680043: Make operator= private in Scheme_hash_table

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by hanwenn
Modified:
3 years, 11 months ago
Reviewers:
hahnjo, haberg-1
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Make operator= private in Scheme_hash_table It was never implemented, but is probably useful to hide.

Patch Set 1 #

Patch Set 2 : jonas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lily/include/scm-hash.hh View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5
hahnjo
If the function is not meant to be implemented / used, it should be explicitly ...
3 years, 11 months ago (2020-04-13 14:55:12 UTC) #1
hanwenn
jonas
3 years, 11 months ago (2020-04-13 15:15:07 UTC) #2
hanwenn
On 2020/04/13 14:55:12, hahnjo wrote: > If the function is not meant to be implemented ...
3 years, 11 months ago (2020-04-13 15:15:20 UTC) #3
hahnjo
LGTM
3 years, 11 months ago (2020-04-13 15:16:30 UTC) #4
haberg-1_telia.com
3 years, 11 months ago (2020-04-13 15:59:05 UTC) #5
> On 13 Apr 2020, at 17:15, hanwenn@gmail.com wrote:
> 
> On 2020/04/13 14:55:12, hahnjo wrote:
>> If the function is not meant to be implemented / used, it should be
> explicitly
>> deleted (C++11).
> 
> Done.
> 
> https://codereview.appspot.com/557680043/

One might prefer having a deleted operator public, as to avoid additional
potentially confusing error messages.


Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b