Revert "Load only the default font for System_start_delimiter"

Revert "Load only the default font for System_start_delimiter"

This reverts commit 430bad24a2d15ec6600e0e780348a0caff29799b.

Regtest for setting SystemStartGrob.style to 'brace

Checks whether the SystemStartBrace is printed

[thomasmorley651, 2020-04-13 11:20:33]

Contains two commits:
[PATCH 2/2] Revert "Load only the default font for System_start_delimiter"
[PATCH 1/2] Regtest for setting SystemStartGrob.style to 'brace

[hahnjo, 2020-04-13 11:38:47]

https://codereview.appspot.com/557670043/diff/569610043/input/regression/syst...
File input/regression/system-start-brace-style.ly (right):

https://codereview.appspot.com/557670043/diff/569610043/input/regression/syst...
input/regression/system-start-brace-style.ly:26: '(SystemStartBracket
SystemStartBrace SystemStartSquare SystemStartBar))
Not being super familiar with Scheme, this took me a while to understand. If I
eventually did (correctly), I think just spelling out the four lines is more
readable:
\new StaffGroup \with { systemStartDelimiter = SystemStartBracket } << b1 b1 >>
\new StaffGroup \with { systemStartDelimiter = SystemStartBrace } << b1 b1 >>
\new StaffGroup \with { systemStartDelimiter = SystemStartSquare } << b1 b1 >>
\new StaffGroup \with { systemStartDelimiter = SystemStartBar } << b1 b1 >>

[lemzwerg, 2020-04-13 11:58:53]

some nits

https://codereview.appspot.com/557670043/diff/569610043/input/regression/syst...
File input/regression/system-start-brace-style.ly (right):

https://codereview.appspot.com/557670043/diff/569610043/input/regression/syst...
input/regression/system-start-brace-style.ly:4: SystemStartGrob's style of
@code{StaffGroup} to @code{'brace}, always prints a
@code{SystemStart@var{Grob}} – and no comma after 'brace

https://codereview.appspot.com/557670043/diff/569610043/input/regression/syst...
input/regression/system-start-brace-style.ly:6: Every @code{StaffGroup} should
start with a @code{SystemStartBrace}.
If you want a new paragraph, please add an empty line before the sentence.

https://codereview.appspot.com/557670043/diff/569610043/lily/system-start-del...
File lily/system-start-delimiter.cc (right):

https://codereview.appspot.com/557670043/diff/569610043/lily/system-start-del...
lily/system-start-delimiter.cc:151: esp. because that triggers mktextfm for
non-existent
mktextfm is no longer relevant to LilyPond since we don't have a TeX back-end
anymore.  Maybe the comment should be just

  We use the style sheet to look up the font file
  name.  This is better than using 'find_font' directly.

[thomasmorley651, 2020-04-13 18:54:33]

Adressing Werner and Jonas

[thomasmorley651, 2020-04-13 18:59:30]

https://codereview.appspot.com/557670043/diff/569610043/input/regression/syst...
File input/regression/system-start-brace-style.ly (right):

https://codereview.appspot.com/557670043/diff/569610043/input/regression/syst...
input/regression/system-start-brace-style.ly:4: SystemStartGrob's style of
@code{StaffGroup} to @code{'brace}, always prints a
On 2020/04/13 11:58:53, lemzwerg wrote:
> @code{SystemStart@var{Grob}} – and no comma after 'brace

Done.

https://codereview.appspot.com/557670043/diff/569610043/input/regression/syst...
input/regression/system-start-brace-style.ly:6: Every @code{StaffGroup} should
start with a @code{SystemStartBrace}.
On 2020/04/13 11:58:53, lemzwerg wrote:
> If you want a new paragraph, please add an empty line before the sentence.

Done.

https://codereview.appspot.com/557670043/diff/569610043/input/regression/syst...
input/regression/system-start-brace-style.ly:26: '(SystemStartBracket
SystemStartBrace SystemStartSquare SystemStartBar))
On 2020/04/13 11:38:47, hahnjo wrote:
> Not being super familiar with Scheme, this took me a while to understand. If I
> eventually did (correctly), I think just spelling out the four lines is more
> readable:
> \new StaffGroup \with { systemStartDelimiter = SystemStartBracket } << b1 b1
>>
> \new StaffGroup \with { systemStartDelimiter = SystemStartBrace } << b1 b1 >>
> \new StaffGroup \with { systemStartDelimiter = SystemStartSquare } << b1 b1 >>
> \new StaffGroup \with { systemStartDelimiter = SystemStartBar } << b1 b1 >>

Done.

https://codereview.appspot.com/557670043/diff/569610043/lily/system-start-del...
File lily/system-start-delimiter.cc (right):

https://codereview.appspot.com/557670043/diff/569610043/lily/system-start-del...
lily/system-start-delimiter.cc:151: esp. because that triggers mktextfm for
non-existent
On 2020/04/13 11:58:53, lemzwerg wrote:
> mktextfm is no longer relevant to LilyPond since we don't have a TeX back-end
> anymore.  Maybe the comment should be just
> 
>   We use the style sheet to look up the font file
>   name.  This is better than using 'find_font' directly.

Done with a third patch. Looks cleaner to leave the revert as is.